Merge branch 'main' into SymbolOrString

Author: Alexander-Barth

.github/workflows/IntegrationTest.yml

@@ -0,0 +1,57 @@
+name: IntegrationTest
+on:
+  push:
+    branches: [main]
+    tags: [v*]
+  pull_request:
+
+concurrency:
+  # Skip intermediate builds: always.
+  # Cancel intermediate builds: only if it is a pull request build.
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
+
+jobs:
+  test:
+    name: ${{ matrix.package.repo }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        julia-version: [1]
+        os: [ubuntu-latest]
+        package:
+          - {user: Alexander-Barth, repo: NCDatasets.jl}
+          - {user: JuliaGeo,        repo: GRIBDatasets.jl}
+          - {user: Alexander-Barth, repo: TIFFDatasets.jl}
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: julia-actions/setup-julia@v1
+        with:
+          version: ${{ matrix.julia-version }}
+          arch: x64
+      - uses: julia-actions/julia-buildpkg@latest
+      - name: Clone Downstream
+        uses: actions/checkout@v2
+        with:
+          repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
+          path: downstream
+      - name: Load this and run the downstream tests
+        shell: julia --project=downstream {0}
+        run: |
+          using Pkg
+          try
+            # force it to use this PR's version of the package
+            Pkg.develop(PackageSpec(path="."))  # resolver may fail with main deps
+            Pkg.update()
+            Pkg.test()  # resolver may fail with test time deps
+          catch err
+            err isa Pkg.Resolve.ResolverError || rethrow()
+            # If we can't resolve that means this is incompatible by SemVer and this is fine
+            # It means we marked this as a breaking change, so we don't need to worry about
+            # Mistakenly introducing a breaking change, as we have intentionally made one
+
+            @info "Not compatible with this release. No problem." exception=err
+            exit(0)  # Exit immediately, as a success
+          end

Project.toml

@@ -4,7 +4,7 @@ authors = ["Alexander Barth <[email protected]>"]
 keywords = ["netcdf", "GRIB", "climate and forecast conventions", "oceanography", "meteorology", "climatology", "opendap"]
 license = "MIT"
 desc = "CommonDataModel is a module that defines types common to NetCDF and GRIB data"
-version = "0.2.2"
+version = "0.2.3"
 
 [deps]
 CFTime = "179af706-886a-5703-950a-314cd64e0468"

README.md

@@ -36,6 +36,17 @@ close(ds)
 
 As a proof-of-concept, there is also an [`TIFFDatasets`](https://github.com/Alexander-Barth/TIFFDatasets.jl) package for GeoTIFF files.
 
+# File conversions
 
+By implementing a common interface, GRIB files can be converted to NetCDF files using
+`NCDatasets.write`:
 
+```julia
+using NCDatasets
+using GRIBDatasets
+using Downloads: download
 
+grib_file = download("https://github.com/JuliaGeo/GRIBDatasets.jl/raw/98356af026ea39a5ec0b5e64e4289105492321f8/test/sample-data/era5-levels-members.grib")
+netcdf_file = "test.nc"
+NCDatasets.write(netcdf_file,GRIBDataset(grib_file))
+```

src/attribute.jl

@@ -40,26 +40,20 @@ function show_attrib(io,a)
     level = get(io, :level, 0)
     indent = " " ^ level
 
-    # if !isopen(ds)
-    #     print(io,"closed Dataset")
-    #     return
-    # end
+    # need to know ds from a
+    #if !isopen(ds)
+    #    print(io,"Dataset attributes (file closed)")
+    #    return
+    #end
 
     try
-        # use the same order of attributes than in the NetCDF file
+        # use the same order of attributes than in the dataset
         for (attname,attval) in a
             print(io,indent,@sprintf("%-20s = ",attname))
             printstyled(io, @sprintf("%s",attval),color=attribute_color[])
             print(io,"\n")
         end
     catch err
         print(io,"Dataset attributes (file closed)")
-        # if isa(err,NetCDFError)
-        #     if err.code == NC_EBADID
-        #         print(io,"Dataset  attributes (file closed)")
-        #         return
-        #     end
-        # end
-        # rethrow()
     end
 end