test with in-memory dataset

Author: Alexander-Barth

src/dimension.jl

@@ -12,7 +12,11 @@ dimnames(ds::Union{AbstractDataset,AbstractVariable}) = ()
 
 Return the length of the dimension `dimname` in the data set `ds`.
 """
-function dim(ds::Union{AbstractDataset,AbstractVariable},dimname::AbstractString)
+function dim(v::AbstractVariable,dimname::AbstractString)
+    error("no dimension $dimname in $(name(v))")
+end
+
+function dim(ds::AbstractDataset,dimname::AbstractString)
     error("no dimension $dimname in $(path(ds))")
 end
 

src/variable.jl

@@ -64,6 +64,7 @@ function Base.show(io::IO,v::AbstractVariable)
             show_attrib(IOContext(io,:level=>level+3),attribs(v))
         end
     catch err
+        @debug "error in show" err
         print(io,"Variable (dataset closed)")
     end
 end

test/Project.toml

@@ -1,4 +1,5 @@
 [deps]
+DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
 GRIBDatasets = "82be9cdb-ee19-4151-bdb3-b400788d9abc"
 NCDatasets = "85f8d34a-cbdd-5861-8df4-14fed0d494ab"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

test/test_scaling.jl

@@ -1,6 +1,7 @@
 using NCDatasets
 using Test
-
+import CommonDataModel as CDM
+using DataStructures
 
 fname = tempname()
 ds = NCDataset(fname,"c")
@@ -24,4 +25,65 @@ v.var[1,1] = 1
 @test ismissing(v[2,2])
 @test fillvalue(v) == fill_value
 
-close(ds)
+@test collect(CDM.dimnames(v)) == ["lon","lat"]
+
+#@test CDM.dim(v,"lon") == 10
+
+io = IOBuffer()
+CDM.show(io,"text/plain",v)
+@test occursin("Attributes",String(take!(io)))
+
+v = @test_warn "numeric" defVar(ds,"temp2",data,("lon","lat"),attrib = Dict(
+    "missing_value" => "bad_idea"))
+
+struct MemoryVariable{T,N} <: CDM.AbstractVariable{T,N}
+    name::String
+    dimnames::Vector{String}
+    data::Array{T,N}
+    attrib::OrderedDict{String,Any}
+end
+
+struct MemoryDataset <: CDM.AbstractDataset
+    dim::OrderedDict{String,Int}
+    variables::OrderedDict{String,MemoryVariable}
+    attrib::OrderedDict{String,Any}
+    unlimited::Vector{String}
+end
+
+data = randn(30,31)
+mv = MemoryVariable("data",["lon","lat"], data, OrderedDict{String,Any}(
+    "units" => "days since 2000-01-01"))
+
+CDM.name(v::MemoryVariable) = v.name
+CDM.dimnames(v::MemoryVariable) = v.dimnames
+Base.size(v::MemoryVariable) = size(v.data)
+
+@test "lon" in CDM.dimnames(mv)
+@test CDM.name(mv) == "data"
+
+md = MemoryDataset(
+    OrderedDict{String,Int}(
+        "lon" => 30,
+        "lat" => 31),
+    OrderedDict{String,MemoryVariable}(
+        "data" => mv),
+    OrderedDict{String,Any}(
+        "history" => "lala"),
+    String[])
+
+import Base
+Base.keys(md::MemoryDataset) = keys(md.variables)
+CDM.variable(md::MemoryDataset,varname::AbstractString) = md.variables[varname]
+Base.getindex(md::MemoryDataset,varname::AbstractString) = CDM.cfvariable(md,varname)
+CDM.dimnames(md::MemoryDataset) = keys(md.dim)
+CDM.dim(md::MemoryDataset,name::AbstractString) = md.dim[name]
+CDM.attribnames(md::Union{MemoryDataset,MemoryVariable}) = keys(md.attrib)
+CDM.attrib(md::Union{MemoryDataset,MemoryVariable},name::AbstractString) = md.attrib[name]
+
+
+io = IOBuffer()
+CDM.show(io,md)
+@test occursin("Attributes",String(take!(io)))
+
+
+#close(ds)