Merge pull request #6 from JuliaGeo/fix/union-missing

Fix correct dimensionality

Author: evetion

src/arrow.jl

@@ -86,7 +86,7 @@ ArrowTypes.fromarrow(::Type{GeoFormatTypes.WellKnownBinary}, x) = GeoFormatTypes
 ArrowTypes.fromarrow(::Type{GeoFormatTypes.WellKnownText}, x) = GeoFormatTypes.WellKnownText(GeoFormatTypes.Geom(), String(x))  # should be StringView
 function ArrowTypes.fromarrow(::Type{Geometry{X}}, x) where {X}
     nt = nested_eltype(x)
-    D = length(nonmissingtype(nt).types)
+    D = length(nt.types)
     return Geometry{X,D,Float64}(x)
 end
 function fromarrow(::Type{GeoArrow.Geometry{X}}, nt::NamedTuple) where X
@@ -95,6 +95,7 @@ end
 ArrowTypes.fromarrow(::Type{Extents.Extent}, x) = Extents.Extent(X=(x.xmin, x.xmax), Y=(x.ymin, x.ymax))
 
 nested_eltype(x) = nested_eltype(typeof(x))
+nested_eltype(::Type{Union{Missing,T}}) where {T} = nested_eltype(T)
 nested_eltype(::Type{T}) where {T<:AbstractArray} = nested_eltype(eltype(T))
 nested_eltype(::Type{T}) where {T} = T
 

src/type.jl

@@ -21,6 +21,7 @@ GeoInterface.ngeom(_, g::Geometry) = length(g.geom)
 GeoInterface.ngeom(t, g::Geometry{X,D,T,<:GeoFormatTypes.MixedFormat}) where {X,D,T} = ngeom(t, g.geom)
 GeoInterface.getgeom(_, g::Geometry, i) = Base.getindex(g, i)
 GeoInterface.getgeom(t, g::Geometry{X,D,T,<:GeoFormatTypes.MixedFormat}, i) where {X,D,T} = getgeom(t, g.geom, i)
+GeoInterface.isempty(::GeoInterface.AbstractGeometryTrait, g::Geometry) = length(g.geom) == 0
 
 # coordtype implementation
 if :coordtype in names(GeoInterface; all = true)