fix Makie plotting LibGEOS MultiLineString shows additional lines #83

Author: jw3126

GeoInterfaceMakie/src/GeoInterfaceMakie.jl

@@ -62,9 +62,13 @@ basicsgeomtype(::GI.MultiPolygonTrait)    = GB.MultiPolygon
 basicsgeomtype(::GI.LineStringTrait)      = GB.LineString
 basicsgeomtype(::GI.MultiLineStringTrait) = GB.MultiLineString
 
-function _convert_arguments(::Type{<:MC.Poly}, geom)::Tuple
+function _convert_arguments(t::Type{<:MC.Poly}, geom)::Tuple
     geob = basicsgeom(geom)::Union{GB.Polygon, GB.MultiPolygon}
-    (geob,)
+    MC.convert_arguments(t,geob)
+end
+function _convert_arguments(t::Type{<:MC.Lines}, geom)::Tuple
+    geob = basicsgeom(geom)
+    MC.convert_arguments(t, geob)
 end
 function _convert_arguments(::MC.PointBased, geom)::Tuple
     pts = points(geom)
@@ -82,6 +86,9 @@ function expr_enable(Geom)
         function $MC.convert_arguments(p::$MC.PointBased, geom::$Geom)
             $_convert_arguments(p,geom)
         end
+        function $MC.convert_arguments(p::Type{<:$MC.Lines}, geom::$Geom)
+            $_convert_arguments(p,geom)
+        end
     end
 end
 

GeoInterfaceMakie/test/runtests.jl

@@ -22,6 +22,15 @@ GeoInterfaceMakie.@enable(LibGEOS.AbstractGeometry)
     ]
 end
 
+@testset "Makie plotting LibGEOS MultiLineString shows additional lines #83" begin
+    mls = readgeom("MULTILINESTRING ((0 0,3 0,3 3,0 3,0 0),(1 1,2 1,2 2,1 2,1 1))")
+    expected = [[0.0, 0.0], [3.0, 0.0], [3.0, 3.0], [0.0, 3.0], [0.0, 0.0], 
+                [NaN, NaN], 
+                [1.0, 1.0], [2.0, 1.0], [2.0, 2.0], [1.0, 2.0], [1.0, 1.0]]
+
+    @test isequal(Makie.convert_arguments(Makie.Lines, mls), (expected,))
+end
+
 @testset "smoketest 2d" begin
     unitsquare = readgeom("POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))")
     bigsquare = readgeom("POLYGON((0 0, 11 0, 11 11, 0 11, 0 0))")