Skip to content

Commit 0900db2

Browse files
asinghvi17rafaqz
andcommitted
Apply suggestions from code review
Co-authored-by: Rafael Schouten <[email protected]>
1 parent 4ccf67b commit 0900db2

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

src/GeometryOps.jl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,10 @@ include("primitives.jl")
3939
include("not_implemented_yet.jl")
4040

4141
include("utils/utils.jl")
42-
4342
include("utils/LoopStateMachine/LoopStateMachine.jl")
44-
using .LoopStateMachine
45-
4643
include("utils/SpatialTreeInterface/SpatialTreeInterface.jl")
47-
using .SpatialTreeInterface
44+
45+
using .LoopStateMachine, .SpatialTreeInterface
4846

4947

5048
include("methods/angles.jl")

src/utils/utils.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,25 +145,20 @@ Returns some iterator, which yields tuples of points. Each tuple is an edge.
145145
It goes `(p1, p2), (p2, p3), (p3, p4), ...` etc.
146146
"""
147147
eachedge(geom) = eachedge(GI.trait(geom), geom, Float64)
148-
149148
function eachedge(geom, ::Type{T}) where T
150149
eachedge(GI.trait(geom), geom, T)
151150
end
152-
153151
# implementation for LineString and LinearRing
154152
function eachedge(trait::GI.AbstractCurveTrait, geom, ::Type{T}) where T
155153
return (_tuple_point.((GI.getpoint(geom, i), GI.getpoint(geom, i+1)), T) for i in 1:GI.npoint(geom)-1)
156154
end
157-
158155
# implementation for Polygon, MultiPolygon, MultiLineString, GeometryCollection
159156
function eachedge(trait::GI.AbstractGeometryTrait, geom, ::Type{T}) where T
160157
return Iterators.flatten((eachedge(r, T) for r in flatten(GI.AbstractCurveTrait, geom)))
161158
end
162-
163159
function eachedge(trait::GI.PointTrait, geom, ::Type{T}) where T
164160
return ArgumentError("Can't get edges from points, $geom was a PointTrait.")
165161
end
166-
167162
function eachedge(trait::GI.MultiPointTrait, geom, ::Type{T}) where T
168163
return ArgumentError("Can't get edges from MultiPoint, $geom was a MultiPointTrait.")
169164
end

0 commit comments

Comments
 (0)