fix crs on polygon clipping #309
Open
+203
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
approved these changes
May 2, 2025
Member
Author
|
Ugh it's not this simple...needs extents too. We should just call tuples and normalize everything when pushing to the array. |
Extend CRS handling from intersection to union and difference operations. Use `mutual_crs` to preserve coordinate reference system information when creating result polygons in non-crossing cases, hole handling, and multipolygon operations. Fixes type mismatches when clipping geometries with different CRS configurations.
asinghvi17
force-pushed
the
as/clipping_crs
branch
from
30bf6b0 to
de4679e
Compare
…g conversion Implements trait-based dispatch in `_linearring` helper to convert LineString geometries (e.g., from ArchGDAL) to LinearRing while preserving CRS metadata. This ensures compatibility with all GeoInterface-compatible geometry types. The function uses trait dispatch pattern: - Returns LinearRing geometries as-is - Converts LineString to LinearRing with CRS preservation - Includes concrete type specializations for GI wrappers (optimization) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds missing CRS parameter propagation in `intersection.jl` to match the pattern already used in union and difference operations. This fixes type conversion errors when using ArchGDAL geometries in intersection operations. Changes: - Pass `crs` parameter to `_trace_polynodes()` call (line 87) - Wrap `tuples()` results with `_linearring()` in non-crossing cases (lines 91, 93) With this fix, all 72 intersection and union operations now succeed across GeoInterface, ArchGDAL, and LibGEOS geometry combinations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rafaqz
requested changes
Nov 9, 2025
| function mutual_crs(a, b) | ||
| if GI.crs(a) == GI.crs(b) | ||
| return GI.crs(a) | ||
| elseif GI.crs(a) == nothing && GI.crs(b) != nothing |
| This is tolerant of `nothing` values in one of a or b, it assumes that they are the same crs. | ||
| """ | ||
| function mutual_crs(a, b) | ||
| if GI.crs(a) == GI.crs(b) |
Member
There was a problem hiding this comment.
This is type unstable.
I think we need to error if they are not nothing but different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, this propagates CRS through polygon clipping.