Skip to content

Commit 267b3e3

Browse files
committed
Fix tests on 1.6
1 parent a8a0c0d commit 267b3e3

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

test/tg/tg_testsets.jl

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,20 @@ function run_testsets(json_file_path)
2323
end && continue
2424

2525
geoms = @. GFT.WellKnownText((GFT.Geom(),), String(testset.geoms))
26-
@testset let testset_index = i
26+
# TODO: this should be a ContextTestSet, BUT
27+
# that is not available in 1.6........
28+
# since I never expect these tests to fail I am fine with the potential noise.
29+
# but in general - DO NOT do this massive testset nesting,
30+
# instead use context to avoid gigantic testset printing.
31+
@testset "testset_index = $i" begin
2732
for (predname, results) in testset.predicates
2833
!haskey(TG_PRED_SYMBOL_TO_FUNCTION, predname) && continue
2934
predname in TG_IGNORE_LIST && continue
3035
predicate_f = TG_PRED_SYMBOL_TO_FUNCTION[predname]
3136

3237
expected = first(results) == "T"
3338

34-
@testset let predicate = predname
39+
@testset "predicate = $predname" begin
3540
@test predicate_f(geoms[1], geoms[2]) == expected
3641
end
3742
end

0 commit comments

Comments
 (0)