more tests

Author: Alexander-Barth

Project.toml

@@ -6,13 +6,15 @@ version = "0.1.0"
 [deps]
 CommonDataModel = "1fbeeb36-5f17-413c-809b-666fb144f157"
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
+DiskArrays = "3c3547ce-8d99-4f5e-a174-61eb10b00ae3"
 Zarr = "0a941bbe-ad1d-11e8-39d9-ab76183a1d99"
 
 [compat]
-julia = "1"
 CommonDataModel = "0.3.4"
 DataStructures = "0.17, 0.18"
+DiskArrays = "0.3.22"
 Zarr = "0.9.2"
+julia = "1"
 
 [extras]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

src/ZarrDatasets.jl

@@ -21,6 +21,10 @@ import CommonDataModel:
     parentdataset,
     variable
 
+import DiskArrays:
+    eachchunk,
+    haschunks
+
 import CommonDataModel as CDM
 using DataStructures
 using Zarr

src/variable.jl

@@ -15,5 +15,7 @@ CDM.attrib(v::ZarrVariable,name::SymbolOrString) = v.zarray.attrs[String(name)]
 
 
 # DiskArray methods
+eachchunk(v::ZarrVariable) = eachchunk(v.zarray)
+haschunks(v::ZarrVariable) = haschunks(v.zarray)
 eachchunk(v::CFVariable{T,N,<:ZarrVariable}) where {T,N} = eachchunk(v.var)
 haschunks(v::CFVariable{T,N,<:ZarrVariable}) where {T,N} = haschunks(v.var)

test/runtests.jl

@@ -1,11 +1,11 @@
+using CommonDataModel: iswritable, attribnames, parentdataset, load!, dataset
 using Dates
+using DiskArrays
 using NCDatasets
 using Test
 using ZarrDatasets
-using CommonDataModel: iswritable, attribnames, parentdataset
 
 @testset "ZarrDatasets.jl" begin
-    #fname = "/tmp/foo.zarr"
     fname = tempname()
     mkpath(fname)
 
@@ -58,7 +58,17 @@ using CommonDataModel: iswritable, attribnames, parentdataset
         Array(ds3["var"])
     end
 
+    @test DiskArrays.haschunks(dsz["var"]) == DiskArrays.Chunked()
+    @test length(DiskArrays.eachchunk(dsz["var"])) ≥ 1
     @test zvar == Array(ds["var"])
+
+    v = dsz["var"].var
+    buffer = zeros(eltype(v),size(v))
+    load!(v,buffer,:,:)
+
+    @test buffer == Array(ds["var"].var)
+
+    @test dataset(dsz["var"]) == dsz
     close(ds)
     close(dsz)
 end