check conversion to km

Author: boriskaus

src/IO_ASAGI.jl

@@ -11,30 +11,31 @@ using NCDatasets: nc_create, NC_NETCDF4, NC_CLOBBER, NC_NOWRITE, nc_def_dim, nc_
 export write_ASAGI, read_ASAGI
 
 """
-    write_ASAGI(fname::String, Data::CartData, 
-                selected_fields::Union{nothing, Tuple}=nothing;
-                km_to_m = false)
+    write_ASAGI(fname::String, Data::CartData; 
+                        fields::Union{Nothing, Tuple}=nothing, 
+                        km_to_m::Bool=false)
     
 Writes a CartData structure `Data` to an ASAGI file, which can be read by SeisSol or ExaHype.
 You can optionally pass a tuple with fields to be written. Note that we can only write individual (scalar) fields to disk,
 so vector or tensor fields needs to be split first
 """
-function write_ASAGI(fname::String, Data::CartData, 
-                        selected_fields::Union{Nothing, Tuple}=nothing;
-                        km_to_m=false)
+function write_ASAGI(fname::String, Data::CartData; 
+                        fields::Union{Nothing, Tuple}=nothing, 
+                        km_to_m::Bool=false)
 
     nx,ny,nz = size(Data.x)
     x = Data.x.val[:,1,1]
     y = Data.y.val[1,:,1]
     z = Data.z.val[1,1,:]
-    if km_to_m
+    if km_to_m==true
+        println("convert to meters")
         x = x.*1000
         y = y.*1000
         z = z.*1000
     end
 
     # Transfer data to a single array with NamedTuple entries
-    material = fields_to_namedtuple(Data.fields, selected_fields)
+    material = fields_to_namedtuple(Data.fields, fields)
 
     fname_asagi = fname*"_ASAGI.nc"
 

test/test_ASAGI_IO.jl

@@ -23,10 +23,15 @@ Data_SeisSol = read_ASAGI("test_files/tpv34_rhomulambda-inner.nc")
 @test eltype(Data_SeisSol.fields.rho[10]) == Float32
 
 # test that specifying specific field works
-fname_asagi = write_ASAGI("test", Data, (:Sxx,))
+fname_asagi = write_ASAGI("test", Data, fields=(:Sxx,))
 Data_ASAGI2 = read_ASAGI(fname_asagi)
 @test sum(Data_ASAGI2.fields.Sxx - Data.fields.Sxx) == 0
 
+# test that converting to meters works
+fname_asagi = write_ASAGI("test3", Data, fields=(:Sxx,), km_to_m=true)
+Data_ASAGI3 = read_ASAGI(fname_asagi)
+@test Data_ASAGI3.x.val[1] ≈ 1000.0
+
 # test that it errors if we use a tuple with non-scalar fields
 @test_throws "Field Stress is not an Array but instead a NTuple{9, Array{Float64, 3}}; only Arrays are supported" write_ASAGI("test", Data_tuple)