Added tests and fixes

Author: Andy Ferris

src/commontransformations.jl

@@ -11,6 +11,7 @@ Construct the `Translation` transformation for translating Cartesian points.
 immutable Translation{T} <: Transformation
     dx::T
 end
+Translation(x::Tuple) = Translation(Vec(x))
 Translation(x,y) = Translation(Vec(x,y))
 Translation(x,y,z) = Translation(Vec(x,y,z))
 Base.show(io::IO, trans::Translation) = print(io, "Translation$((trans.dx...))")
@@ -19,6 +20,8 @@ function transform(trans::Translation, x)
     x + trans.dx
 end
 
+transform(trans::Translation, x::Tuple) = Tuple(Vec(x) + trans.dx)
+
 Base.inv(trans::Translation) = Translation(-trans.dx)
 
 function compose(trans1::Translation, trans2::Translation)
@@ -169,6 +172,8 @@ function transform(trans::Rotation, x::FixedVector{3})
     (typeof(x2))(m * Vec(x2))
 end
 
+transform(trans::Rotation, x::Tuple) = Tuple(transform(trans, Vec(x)))
+
 transform_deriv(trans::Rotation, x) = trans.matrix # It's a linear transformation, so this is easy!
 
 function transform_deriv_params{T}(trans::Rotation{Void,T}, x)
@@ -339,7 +344,7 @@ function transform(trans::RotationYZ, x::FixedVector{3})
     (sincos, x2) = promote(Vec(trans.sin, trans.cos), x)
     (typeof(x2))(x2[1], x[2]*sincos[2] - x[3]*sincos[1], x[2]*sincos[1] + x[3]*sincos[2])
 end
-function transform{T}(trans::RotationXY{T}, x)
+function transform{T}(trans::RotationYZ{T}, x)
     Z = zero(T)
     I = one(T)
 
@@ -348,13 +353,13 @@ function transform{T}(trans::RotationXY{T}, x)
      Z trans.sin  trans.cos] * x
 end
 
-transform(trans::RotationZX, x::Vector) =    [x[3]*trans.cos - x[1]*trans.sin, x[2], x[3]*trans.sin + x[1]*trans.cos]
-transform(trans::RotationZX, x::NTuple{3}) = (x[3]*trans.cos - x[1]*trans.sin, x[2], x[3]*trans.sin + x[1]*trans.cos)
+transform(trans::RotationZX, x::Vector) =    [x[3]*trans.sin + x[1]*trans.cos, x[2], x[3]*trans.cos - x[1]*trans.sin]
+transform(trans::RotationZX, x::NTuple{3}) = (x[3]*trans.sin + x[1]*trans.cos, x[2], x[3]*trans.cos - x[1]*trans.sin)
 function transform(trans::RotationZX, x::FixedVector{3})
     (sincos, x2) = promote(Vec(trans.sin, trans.cos), x)
     (typeof(x2))(x[3]*sincos[1] + x[1]*sincos[2], x2[2], x[3]*sincos[2] - x[1]*sincos[1])
 end
-function transform{T}(trans::RotationXY{T}, x)
+function transform{T}(trans::RotationZX{T}, x)
     Z = zero(T)
     I = one(T)
 

test/commontransformations.jl

@@ -11,6 +11,8 @@
 
         # Transform
         @test transform(trans, x) === Point(3.0, 1.0)
+        @test transform(trans, Tuple(x)) === (3.0, 1.0)
+        @test transform(trans, collect(x)) === Vec(3.0, 1.0)
 
         # Transform derivative
         m1 = transform_deriv(trans, x)
@@ -61,6 +63,8 @@
 
         # Transform
         @test transform(trans, x) ≈ x2
+        @test Vec(transform(trans, Tuple(x))) ≈ x2
+        @test transform(trans, collect(x)) ≈ collect(x2)
 
         # Transform derivative
         x = Point(2.0,1.0)
@@ -116,6 +120,9 @@
 
             y = transform(trans, x)
             @test y == R * Vec(1.0, 2.0, 3.0)
+            @test transform(trans, Tuple(x)) == Tuple(R * Vec(1.0, 2.0, 3.0))
+            @test transform(trans, collect(x)) == R * Vec(1.0, 2.0, 3.0)
+
 
             x_gn = Point(Dual(1.0,(1.,0.,0.)), Dual(2.0,(0.,1.,0.)), Dual(3.0,(0.,0.,1.)))
             y_gn = transform(trans, x_gn)
@@ -219,6 +226,8 @@
 
             # Transform
             @test transform(trans, x) ≈ x2
+            @test Vec(transform(trans, Tuple(x))) ≈ x2
+            @test Vec(transform(trans, collect(x))) ≈ x2
 
             # Transform derivative
             x = Point(2.0,1.0,3.0)
@@ -257,6 +266,8 @@
 
             # Transform
             @test transform(trans, x) ≈ x2
+            @test Vec(transform(trans, Tuple(x))) ≈ x2
+            @test Vec(transform(trans, collect(x))) ≈ x2
 
             # Transform derivative
             x = Point(2.0,1.0,3.0)
@@ -295,6 +306,8 @@
 
             # Transform
             @test transform(trans, x) ≈ x2
+            @test Vec(transform(trans, Tuple(x))) ≈ x2
+            @test Vec(transform(trans, collect(x))) ≈ x2
 
             # Transform derivative
             x = Point(2.0,1.0,3.0)

test/coordinatesystems.jl

@@ -22,6 +22,8 @@
         xy = Point(1.0, 2.0)
         rθ = Polar(2.23606797749979, 1.1071487177940904)
         @test transform(p_from_c, xy) ≈ rθ
+        @test transform(p_from_c, Tuple(xy)) ≈ rθ
+        @test transform(p_from_c, collect(xy)) ≈ rθ
         @test transform(c_from_p, rθ) ≈ xy
 
         # TODO - define some convenience functions to create the gradient numbers and unpack the arrays.
@@ -142,6 +144,8 @@
         xyz = Point(1.0, 2.0, 3.0)
         rθϕ = Spherical(3.7416573867739413, 1.1071487177940904, 0.9302740141154721)
         @test transform(s_from_cart, xyz) ≈ rθϕ
+        @test transform(s_from_cart, Tuple(xyz)) ≈ rθϕ
+        @test transform(s_from_cart, collect(xyz)) ≈ rθϕ
         @test transform(cart_from_s, rθϕ) ≈ xyz
 
         xyz_gn = Point(Dual(1.0, (1.0, 0.0, 0.0)), Dual(2.0, (0.0, 1.0, 0.0)), Dual(3.0, (0.0, 0.0, 1.0)))
@@ -321,6 +325,8 @@
         xyz = Point(1.0, 2.0, 3.0)
         rθz = Cylindrical(2.23606797749979, 1.1071487177940904, 3.0)
         @test transform(cyl_from_cart, xyz) ≈ rθz
+        @test transform(cyl_from_cart, Tuple(xyz)) ≈ rθz
+        @test transform(cyl_from_cart, collect(xyz)) ≈ rθz
         @test transform(cart_from_cyl, rθz) ≈ xyz
 
         xyz_gn = Point(Dual(1.0, (1.0, 0.0, 0.0)), Dual(2.0, (0.0, 1.0, 0.0)), Dual(3.0, (0.0, 0.0, 1.0)))