bring back integer rounding (#242)

* bring back integer rounding

* add round() method and fix ambiguity

* skip round() for now

Author: ffreyer

src/primitives/rectangles.jl

@@ -9,6 +9,13 @@ Formally it is the Cartesian product of intervals, which is represented by the
 struct HyperRectangle{N,T} <: GeometryPrimitive{N,T}
     origin::Vec{N,T}
     widths::Vec{N,T}
+
+    function HyperRectangle{N, T}(o::VecTypes, w::VecTypes) where {N, T}
+        return new{N, T}(convert(Vec{N, T}, o), convert(Vec{N, T}, w))
+    end
+    function HyperRectangle{N, T}(o::VecTypes, w::VecTypes) where {N, T <: Integer}
+        return new{N, T}(convert(Vec{N, T}, round.(T, o)), convert(Vec{N, T}, round.(T, w)))
+    end
 end
 
 ##
@@ -154,6 +161,12 @@ height(prim::Rect) = prim.widths[2]
 volume(prim::HyperRectangle) = prod(prim.widths)
 area(prim::Rect2) = volume(prim)
 
+# function Base.round(::Type{Rect{N, T}}, x::Rect{N}, mode::RoundingMode=RoundNearest) where {N, T}
+#     mini = round.(T, minimum(x))
+#     maxi = round.(T, maximum(x))
+#     return Rect{N, T}(mini, maxi .- mini)
+# end
+
 """
     split(rectangle, axis, value)
 

test/geometrytypes.jl

@@ -182,6 +182,13 @@ end
         end
     end
 
+    # TODO: consider deprecating this
+    @testset "Integer rounding" begin
+        @test Rect2i(0.3, 0.4, 0.6, 0.5) == Rect2i(0,0,1,0)
+        @test Rect2{UInt32}(0.8, 0.1, 1.3, 1.9) == Rect2i(1,0,1,2)
+        @test Rect3i(0.3, 0.6, 0.9, 1.2, 1.5, 1.8) == Rect3i(0,1,1,1,2,2)
+    end
+
     # TODO: These don't really make sense...
     r = Rect2f()
     @test origin(r) == Vec(Inf, Inf)