add tests for missed functions

Author: ffreyer

src/geometry_primitives.jl

@@ -145,6 +145,8 @@ end
 Calculates an orthogonal vector to a polygon defined by a vector of ordered
 `points`. Note that the orthogonal vector to a collection of 2D points needs to
 expand to 3D space.
+
+Note that this vector is not normalized.
 """
 function orthogonal_vector(::Type{VT}, vertices) where {VT <: VecTypes{3}}
     c = zeros(VT) # Inherit vector type from input
@@ -157,6 +159,17 @@ function orthogonal_vector(::Type{VT}, vertices) where {VT <: VecTypes{3}}
     return c
 end
 
+function orthogonal_vector(::Type{VT}, vertices::Tuple) where {VT <: VecTypes{3}}
+    c = zeros(VT) # Inherit vector type from input
+    prev = to_ndim(VT, last(vertices), 0)
+    @inbounds for p in vertices # Use shoelace approach
+        v = to_ndim(VT, p, 0)
+        c += cross(prev, v) # Add each edge contribution
+        prev = v
+    end
+    return c
+end
+
 # Not sure how useful this fast path is, but it's simple to keep
 function orthogonal_vector(::Type{VT}, triangle::Triangle) where {VT <: VecTypes{3}}
     a, b, c = triangle

test/geometrytypes.jl

@@ -334,12 +334,28 @@ end
 
 @testset "orthogonal_vector" begin
     tri = Triangle(Point3d(0,0,0), Point3d(1,0,0), Point3d(0,1,0))
-    @test GeometryBasics.orthogonal_vector(tri) == Vec3d(0,0,1)
-    @test GeometryBasics.orthogonal_vector(collect(coordinates(tri))) == Vec3d(0,0,1)
+    @test GeometryBasics.orthogonal_vector(tri) === Vec3d(0,0,1)
+    @test GeometryBasics.orthogonal_vector(collect(coordinates(tri))) === Vec3d(0,0,1)
+    @test GeometryBasics.orthogonal_vector(Vec3f, tri) === Vec3f(0,0,1)
+    @test GeometryBasics.orthogonal_vector(Vec3f, collect(coordinates(tri))) === Vec3f(0,0,1)
 
     quad = GeometryBasics.Quadrilateral(Point2i(0,0), Point2i(1,0), Point2i(1,1), Point2i(0,1))
-    @test GeometryBasics.orthogonal_vector(quad) == Vec3i(0,0,2)
-    @test GeometryBasics.orthogonal_vector(collect(coordinates(quad))) == Vec3i(0,0,2)
+    @test GeometryBasics.orthogonal_vector(quad) === Vec3i(0,0,2)
+    @test GeometryBasics.orthogonal_vector(collect(coordinates(quad))) === Vec3i(0,0,2)
+    @test GeometryBasics.orthogonal_vector(Vec3d, quad) === Vec3d(0,0,2)
+    @test GeometryBasics.orthogonal_vector(Vec3d, collect(coordinates(quad))) === Vec3d(0,0,2)
+
+    t = (Point3f(0), Point3f(1,0,1), Point3f(0,1,0))
+    @test GeometryBasics.orthogonal_vector(t) == Vec3f(-1,0,1)
+    @test GeometryBasics.orthogonal_vector(Vec3i, t) == Vec3i(-1,0,1)#
+
+    # Maybe the ::Any fallback is too generic...?
+    struct TestType
+        data::Vector{Vec3f}
+    end
+    GeometryBasics.coordinates(x::TestType) = x.data
+    x = TestType([Point3f(1,1,1), Point3f(0,0,0), Point3f(0.5,0,0)])
+    @test GeometryBasics.orthogonal_vector(x) == Vec3f(0, -0.5, 0.5)
 end
 
 @testset "Normals" begin