fix tests

Author: ffreyer

src/meshes.jl

@@ -213,8 +213,10 @@ end
 Calculate the signed volume of one tetrahedron. Be sure the orientation of your
 surface is right.
 """
-function volume(triangle::Triangle)
-    v1, v2, v3 = triangle
+volume(triangle::Triangle) = volume(triangle...)
+volume(ps::SVector{3, <: VecTypes}) = volume(ps...)
+
+function volume(v1, v2, v3)
     sig = sign(orthogonal_vector(v1, v2, v3) ⋅ v1)
     return sig * abs(v1 ⋅ (v2 × v3)) / 6
 end

test/geometrytypes.jl

@@ -298,10 +298,10 @@ end
 
     ps = rand(Point2f, 10)
     f = GLTriangleFace(1, 2, 3)
-    @test ps[f] == Triangle(ps[[1,2,3]]...)
+    @test ps[f] == GeometryBasics.@SVector [ps[1], ps[2], ps[3]]
     data = [string(i) for i in 1:10]
     f = QuadFace(3, 4, 7, 8)
-    @test data[f] == ("3", "4", "7", "8")
+    @test data[f] == ["3", "4", "7", "8"]
 
     @test GeometryBasics.cyclic_hash(f) != GeometryBasics.cyclic_hash(QuadFace(1,2,3,4))
     @test GeometryBasics.cyclic_hash(f) == GeometryBasics.cyclic_hash(QuadFace(3,4,7,8))

test/meshes.jl

@@ -11,15 +11,15 @@ end
     f = [TriangleFace(1, 2, 3), QuadFace(1, 2, 3, 4)]
     p = Point2f[(0, 1), (1, 2), (3, 4), (4, 5)]
     m = Mesh(p, f)
-    @test collect(m) == [Triangle(p[1], p[2], p[3]), GeometryBasics.Quadrilateral(p[1], p[2], p[3], p[4])]
+    @test collect(m) == [GeometryBasics.SVector(p[1], p[2], p[3]), GeometryBasics.SVector(p[1], p[2], p[3], p[4])]
 end
 
 @testset "Heterogenous faces" begin
     # https://github.com/JuliaGeometry/GeometryBasics.jl/issues/142
     f = [TriangleFace(1, 2, 3), QuadFace(1, 2, 3, 4)]
     p = Point2f[(0, 1), (1, 2), (3, 4), (4, 5)]
     m = Mesh(p, f)
-    @test collect(m) == [Triangle(p[1], p[2], p[3]), GeometryBasics.Quadrilateral(p[1], p[2], p[3], p[4])]
+    @test collect(m) == [GeometryBasics.SVector(p[1], p[2], p[3]), GeometryBasics.SVector(p[1], p[2], p[3], p[4])]
 end
 
 @testset "Ambiguous NgonFace constructors" begin

test/runtests.jl

@@ -136,7 +136,7 @@ end
         points = connect([1, 2, 3, 4, 5, 6, 7, 8], Point{2})
         f = connect([1, 2, 3, 4], SimplexFace{4})
         mesh = Mesh(points, f)
-        @test collect(mesh) == [Tetrahedron(points...)]
+        @test collect(mesh) == [GeometryBasics.SVector(points...)]
         @test faces(mesh) == [TetrahedronFace{Int64}(1,2,3,4)]
         @test decompose(LineFace{Int64}, mesh) == LineFace{Int64}[(1, 2), (1, 3), (1, 4), (2, 3), (2, 4), (3, 4)]
         @test decompose(GLTriangleFace, mesh) == GLTriangleFace[(2, 3, 4), (1, 3, 4), (1, 2, 4), (1, 2, 3)]