make Rects have positive widths

Author: ffreyer

src/primitives/rectangles.jl

@@ -9,6 +9,10 @@ Formally it is the Cartesian product of intervals, which is represented by the
 struct HyperRectangle{N,T} <: GeometryPrimitive{N,T}
     origin::Vec{N,T}
     widths::Vec{N,T}
+
+    function HyperRectangle{N, T}(origin::VecTypes, widths::VecTypes) where {N, T}
+        return new{N, T}(Vec{N, T}(min.(origin, origin .+ widths)), Vec{N, T}(abs.(widths)))
+    end
 end
 
 ##
@@ -288,12 +292,7 @@ end
 #     return vmin, vmax
 # end
 
-function positive_widths(rect::Rect{N,T}) where {N,T}
-    mini, maxi = minimum(rect), maximum(rect)
-    realmin = min.(mini, maxi)
-    realmax = max.(mini, maxi)
-    return Rect{N,T}(realmin, realmax .- realmin)
-end
+positive_widths(rect::Rect{N,T}) where {N,T} = rect
 
 ###
 # set operations

test/geometrytypes.jl

@@ -78,8 +78,6 @@ end
 
 @testset "HyperRectangles" begin
     @testset "Constructors" begin
-        # TODO: Do these actually make sense?
-        # Should they not be Rect(NaN..., 0...)?
         @testset "Empty Constructors" begin
             function nan_equal(r1::Rect, r2::Rect)
                 o1 = origin(r1); o2 = origin(r2)
@@ -192,6 +190,11 @@ end
                 @test constructor(m)                                                 ≈ Rect3f(-1, -1, -1, 2, 2, 2)
             end
         end
+
+        r = Rect2f(10, 10, -5, -5)
+        @test origin(r) == Point2f(5)
+        @test widths(r) == Vec2f(5)
+        @test maximum(r) == Point2f(10)
     end
 
     r = Rect2f()