Merge pull request #184 from jw3126/geominterface

add missing ncoord methods for (Multi)LineString

Author: SimonDanisch

src/geointerface.jl

@@ -31,6 +31,7 @@ GeoInterface.ngeom(::LineTrait, g::Line) = length(g)
 GeoInterface.getgeom(::LineTrait, g::Line, i::Int) = g[i]
 
 GeoInterface.ngeom(::LineStringTrait, g::LineString) = length(g) + 1  # n line segments + 1
+GeoInterface.ncoord(::LineStringTrait, g::LineString{Dim}) where {Dim} = Dim
 function GeoInterface.getgeom(::LineStringTrait, g::LineString, i::Int)
     return GeometryBasics.coordinates(g)[i]
 end
@@ -52,6 +53,7 @@ function GeoInterface.getgeom(::MultiLineStringTrait, g::MultiLineString,
                               i::Int)
     return g[i]
 end
+GeoInterface.ncoord(::MultiLineStringTrait, g::MultiLineString{Dim}) where {Dim} = Dim
 
 GeoInterface.ngeom(::MultiPolygonTrait, g::MultiPolygon) = length(g)
 GeoInterface.getgeom(::MultiPolygonTrait, g::MultiPolygon, i::Int) = g[i]

test/geointerface.jl

@@ -14,6 +14,7 @@
     linestring = LineString(Point{2,Int}[(10, 10), (20, 20), (10, 40)])
     @test testgeometry(linestring)
     @test ngeom(linestring) == 3
+    @test ncoord(linestring) == 2
     @test getgeom(linestring, 1) == Point(10, 10)
     @test getgeom(linestring, 2) == Point(20, 20)
     @test getgeom(linestring, 3) == Point(10, 40)
@@ -23,6 +24,7 @@
     @test testgeometry(multilinestring)
     @test GeoInterface.coordinates(multilinestring) ==
           [[[10, 10], [20, 20], [10, 40]], [[10, 10], [20, 20], [10, 40]]]
+    @test ncoord(multilinestring) == 2
 
     poly = Polygon(rand(Point{2,Float32}, 5), [rand(Point{2,Float32}, 5)])
     @test testgeometry(poly)