cleanup normal gen and export face_normals

Author: ffreyer

src/GeometryBasics.jl

@@ -41,6 +41,7 @@ export AbstractFace, TriangleFace, QuadFace, GLTriangleFace
 export OffsetInteger, ZeroIndex, OneIndex, GLIndex
 export decompose, coordinates, faces, normals, decompose_uv, decompose_normals,
        texturecoordinates, vertex_attributes
+export face_normals
 export Tesselation, Normal, UV, UVW
 export AbstractMesh, Mesh, MetaMesh, FaceView
 

src/geometry_primitives.jl

@@ -160,10 +160,6 @@ function normals(vertices::AbstractVector{Point{3,T}}, faces::AbstractVector{F};
     return normals(vertices, faces, normaltype)
 end
 
-function normals(primitive::GeometryPrimitive{3, T}; normaltype=Vec{3,T}) where {T}
-    return normals(coordinates(primitive), faces(primitive), normaltype)
-end
-
 function normals(vertices::AbstractVector{<:Point{3}}, faces::AbstractVector{F},
                  ::Type{NormalType}) where {F<:NgonFace,NormalType}
 
@@ -185,17 +181,9 @@ end
 """
     face_normals(positions::Vector{Point3{T}}, faces::Vector{<: NgonFace}[, target_type = Vec3{T}])
 
-Compute vertex normals from the given `positions` and `faces`.
-
-This runs through all faces, computing a face normal each and adding it to every
-involved vertex. The direction of the face normal is based on winding direction 
-and assumed counter-clockwise faces. At the end the summed face normals are 
-normalized again to produce a vertex normal.
+Compute face normals from the given `positions` and `faces` and returns an
+appropriate `FaceView`.
 """
-function face_normals(primitive::GeometryPrimitive{3, T}; normaltype = Vec{3, T}) where {T}
-    return face_normals(coordinates(primitive), faces(primitive), normaltype)
-end
-
 function face_normals(
         positions::AbstractVector{<:Point3{T}}, fs::AbstractVector{<: AbstractFace}; 
         normaltype = Vec3{T}) where {T}

test/runtests.jl

@@ -298,7 +298,7 @@ end
 @testset "Face normals" begin
     r = Rect3f(Point3f(0), Vec3f(1))
     ns = normals(r)
-    @test GeometryBasics.face_normals(r) == ns
+    @test GeometryBasics.face_normals(coordinates(r), faces(r)) == ns
 end
 
 @testset "Tests from GeometryTypes" begin