Hook up vectors of Points and vectors of those to GeoInterface #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vector{Point} is a LineString
Vector{Vector{Point}} is a MultiLineString
Need this for the generic datashader thing :)
|
Isn't it ambiguous what a vector of points is though? It could be a MultiPoint or a LineString or a LinearRing... Why not just wrap them before use? |
|
If we implement the bin counting with OpenGL, we could just use all of the normal rendering pipeline |
|
Also this is directly clashing with my other PR... I was removing vectors completely as geometries 😅 |
|
I guess we can close this? |
|
Yeah I think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector{Point} is a LineString
Vector{Vector{Point}} is a MultiLineString
Need this for the generic datashader thing :)