Add 3D capability to earcut_triangulate #225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method assumes two things: - The first three points in the polygon are not NaN - The first three points in the polygon are all different - The polygon lies in a single plane, that can be described by its first three points
|
This might be better placed in Makie - closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method assumes three things:
It simply creates a plane from the first three points of the polygon, and projects the rest of the polygon onto it. Then, EarCut can triangulate the polygon by the usual method for 2D.
This will enable plotting 3D polygons in GLMakie and WGLMakie with no extra steps, CairoMakie needs some more fixes it seems. But we're getting there!
Fixes MakieOrg/Makie.jl#4015, and the other issue someone raised about a set of polygons in 3D that I can't find anymore.
Probably needs tests, but not sure what a good test suite would be? Ideas appreciated :)
cc @milankl - this is the algorithm I sent you on Slack