-
Notifications
You must be signed in to change notification settings - Fork 5
Implement _zeros and _ones utils #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 95.81% 95.90% +0.08%
==========================================
Files 17 17
Lines 287 293 +6
==========================================
+ Hits 275 281 +6
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only have one minor comment.
Co-authored-by: Joshua Lampert <[email protected]>
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Changes
_zerosand_onesutility functions. These act likeBase.zerosandBase.ones, respectively, but returnNTuples to eliminate some allocations.HAdaptiveCubatureintegrals, up to about 2.7x for particularly simple integrals.Notes