Obsolete use of nested GaussKronrod rules#196
Merged
mikeingold merged 11 commits intomainfrom Aug 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 198 192 -6
=========================================
- Hits 198 192 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
JoshuaLampert
requested changes
Aug 13, 2025
Member
JoshuaLampert
left a comment
There was a problem hiding this comment.
Thanks! It's nice to see that this cut down CI time in half!
Collaborator
Author
|
Thanks for the good feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GaussKronrodrules (geometries with more than one parametric dimension).GaussKronrodcombinations and add another test geometry._error_unsupported_combinationsince it is currently only used in one place.