-
Notifications
You must be signed in to change notification settings - Fork 5
Obsolete use of nested GaussKronrod rules #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 198 192 -6
=========================================
- Hits 198 192 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's nice to see that this cut down CI time in half!
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks for the good feedback! |
Changes
GaussKronrodrules (geometries with more than one parametric dimension).GaussKronrodcombinations and add another test geometry._error_unsupported_combinationsince it is currently only used in one place.