Skip to content

Conversation

@mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Aug 13, 2025

Changes

  • (Breaking) Removed support for use of nested GaussKronrod rules (geometries with more than one parametric dimension).
  • Updated benchmarks to remove unsupported GaussKronrod combinations and add another test geometry.
  • Removed _error_unsupported_combination since it is currently only used in one place.

@mikeingold mikeingold self-assigned this Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (68f022f) to head (3428093).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          198       192    -6     
=========================================
- Hits           198       192    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 3428093... main / 3428093...
Differentials/Differential 0.207 ± 0.002 μs 0.205 ± 0.001 μs 1.01 ± 0.011
Differentials/Jacobian 0.169 ± 0.0001 μs 0.169 ± 0.001 μs 0.999 ± 0.0059
Integrals/Segment/Scalar GaussKronrod 0.621 ± 0.01 μs 0.631 ± 0.01 μs 0.984 ± 0.022
Integrals/Segment/Scalar GaussLegendre 1.64 ± 0.01 μs 1.64 ± 0.02 μs 1 ± 0.014
Integrals/Segment/Scalar HAdaptiveCubature 0.862 ± 0.05 μs 0.851 ± 0.05 μs 1.01 ± 0.084
Integrals/Segment/Vector GaussKronrod 3.16 ± 0.23 μs 2.71 ± 0.23 μs 1.17 ± 0.13
Integrals/Segment/Vector GaussLegendre 17.4 ± 0.48 μs 17.3 ± 0.45 μs 1 ± 0.038
Integrals/Segment/Vector HAdaptiveCubature 3.92 ± 0.29 μs 3.62 ± 0.3 μs 1.08 ± 0.12
Integrals/Sphere/Scalar GaussKronrod 1.13 ± 0.01 μs 1.11 ± 0.001 μs 1.02 ± 0.009
Integrals/Sphere/Scalar GaussLegendre 1.87 ± 0.0049 ms 1.87 ± 0.0037 ms 1 ± 0.0033
Integrals/Sphere/Scalar HAdaptiveCubature 0.0478 ± 0.00013 ms 0.0477 ± 0.00015 ms 1 ± 0.0042
Integrals/Sphere/Vector GaussKronrod 3.55 ± 0.21 μs 3.39 ± 0.22 μs 1.05 ± 0.092
Integrals/Sphere/Vector GaussLegendre 3.26 ± 0.062 ms 3.26 ± 0.054 ms 1 ± 0.025
Integrals/Sphere/Vector HAdaptiveCubature 0.102 ± 0.0015 ms 0.0988 ± 0.0011 ms 1.04 ± 0.019
Rules/GaussLegendre 21.8 ± 0.54 μs 21.9 ± 0.53 μs 1 ± 0.035
Specializations/Scalar GaussLegendre/BezierCurve 0.251 ± 0.0069 ms 0.252 ± 0.0071 ms 0.993 ± 0.039
Specializations/Scalar GaussLegendre/Line 6.94 ± 0.09 μs 7.14 ± 0.089 μs 0.972 ± 0.017
Specializations/Scalar GaussLegendre/Plane 0.745 ± 0.0018 ms 0.745 ± 0.0017 ms 1 ± 0.0033
Specializations/Scalar GaussLegendre/Ray 5.95 ± 0.06 μs 5.88 ± 0.05 μs 1.01 ± 0.013
Specializations/Scalar GaussLegendre/Rope 0.0539 ± 0.00019 ms 0.0517 ± 0.00029 ms 1.04 ± 0.0069
Specializations/Scalar GaussLegendre/Tetrahedron 0.156 ± 0.0013 s 0.154 ± 0.0014 s 1.01 ± 0.012
Specializations/Scalar GaussLegendre/Triangle 0.61 ± 0.0075 ms 0.603 ± 0.0076 ms 1.01 ± 0.018
time_to_load 1.43 ± 0.018 s 1.42 ± 0.035 s 1.01 ± 0.028
Memory benchmarks
main 3428093... main / 3428093...
Differentials/Differential 3 allocs: 0.0938 kB 3 allocs: 0.0938 kB 1
Differentials/Jacobian 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Segment/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar HAdaptiveCubature 7 allocs: 0.492 kB 7 allocs: 0.492 kB 1
Integrals/Segment/Vector GaussKronrod 0.063 k allocs: 4.88 kB 0.063 k allocs: 4.88 kB 1
Integrals/Segment/Vector GaussLegendre 0.606 k allocs: 0.04 MB 0.606 k allocs: 0.04 MB 1
Integrals/Segment/Vector HAdaptiveCubature 0.085 k allocs: 6.75 kB 0.085 k allocs: 6.75 kB 1
Integrals/Sphere/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Sphere/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Sphere/Scalar HAdaptiveCubature 7 allocs: 0.648 kB 7 allocs: 0.648 kB 1
Integrals/Sphere/Vector GaussKronrod 0.063 k allocs: 4.88 kB 0.063 k allocs: 4.88 kB 1
Integrals/Sphere/Vector GaussLegendre 0.06 M allocs: 3.97 MB 0.06 M allocs: 3.97 MB 1
Integrals/Sphere/Vector HAdaptiveCubature 1.42 k allocs: 0.108 MB 1.42 k allocs: 0.108 MB 1
Rules/GaussLegendre 7 allocs: 0.0325 MB 7 allocs: 0.0325 MB 1
Specializations/Scalar GaussLegendre/BezierCurve 23 allocs: 0.75 kB 23 allocs: 0.75 kB 1
Specializations/Scalar GaussLegendre/Line 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Plane 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
Specializations/Scalar GaussLegendre/Ray 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Rope 0.068 k allocs: 1.62 kB 0.068 k allocs: 1.62 kB 1
Specializations/Scalar GaussLegendre/Tetrahedron 3 M allocs: 0.179 GB 3 M allocs: 0.179 GB 1
Specializations/Scalar GaussLegendre/Triangle 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@mikeingold mikeingold marked this pull request as ready for review August 13, 2025 03:12
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's nice to see that this cut down CI time in half!

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikeingold
Copy link
Collaborator Author

Thanks for the good feedback!

@mikeingold mikeingold merged commit e94fbfa into main Aug 14, 2025
12 checks passed
@mikeingold mikeingold deleted the depgk branch August 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants