Skip to content

Conversation

@mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Aug 14, 2025

Changes

  • Increase minimum compat for Meshes.jl to v0.52.12 which implemented new geometry types.
  • Increase minimum compat for CoordRefSystems.jl to v0.16.0 match Meshes.jl at v0.52.12.
  • Removes minimum package version checks for the affected geometry tests.

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e94fbfa) to head (eb7bf18).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          192       192           
=========================================
  Hits           192       192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main eb7bf18... main / eb7bf18...
Differentials/Differential 0.204 ± 0.0011 μs 0.205 ± 0.0019 μs 0.995 ± 0.011
Differentials/Jacobian 0.17 ± 0.001 μs 0.169 ± 0.001 μs 1.01 ± 0.0084
Integrals/Segment/Scalar GaussKronrod 0.621 ± 0.011 μs 0.621 ± 0.01 μs 1 ± 0.024
Integrals/Segment/Scalar GaussLegendre 1.67 ± 0.01 μs 1.66 ± 0.011 μs 1.01 ± 0.009
Integrals/Segment/Scalar HAdaptiveCubature 0.842 ± 0.051 μs 0.822 ± 0.031 μs 1.02 ± 0.073
Integrals/Segment/Vector GaussKronrod 2.71 ± 0.23 μs 2.73 ± 0.26 μs 0.993 ± 0.13
Integrals/Segment/Vector GaussLegendre 17.7 ± 0.48 μs 17.6 ± 0.49 μs 1.01 ± 0.039
Integrals/Segment/Vector HAdaptiveCubature 3.62 ± 0.28 μs 3.7 ± 0.38 μs 0.978 ± 0.13
Integrals/Sphere/Scalar GaussKronrod 1.13 ± 0.011 μs 1.13 ± 0.011 μs 1 ± 0.014
Integrals/Sphere/Scalar GaussLegendre 1.87 ± 0.0053 ms 1.87 ± 0.0027 ms 0.998 ± 0.0032
Integrals/Sphere/Scalar HAdaptiveCubature 0.0476 ± 0.00016 ms 0.0476 ± 0.0001 ms 0.999 ± 0.004
Integrals/Sphere/Vector GaussKronrod 3.34 ± 0.2 μs 3.39 ± 0.21 μs 0.985 ± 0.085
Integrals/Sphere/Vector GaussLegendre 3.39 ± 0.088 ms 3.27 ± 0.053 ms 1.03 ± 0.032
Integrals/Sphere/Vector HAdaptiveCubature 0.0983 ± 0.0013 ms 0.0993 ± 0.0012 ms 0.991 ± 0.018
Rules/GaussLegendre 22 ± 0.53 μs 22.1 ± 0.52 μs 1 ± 0.034
Specializations/Scalar GaussLegendre/BezierCurve 0.252 ± 0.0072 ms 0.243 ± 0.0071 ms 1.04 ± 0.042
Specializations/Scalar GaussLegendre/Line 7.05 ± 0.09 μs 6.89 ± 0.07 μs 1.02 ± 0.017
Specializations/Scalar GaussLegendre/Plane 0.745 ± 0.002 ms 0.744 ± 0.002 ms 1 ± 0.0038
Specializations/Scalar GaussLegendre/Ray 5.89 ± 0.06 μs 5.89 ± 0.05 μs 1 ± 0.013
Specializations/Scalar GaussLegendre/Rope 0.0516 ± 0.00026 ms 0.0505 ± 0.00027 ms 1.02 ± 0.0075
Specializations/Scalar GaussLegendre/Tetrahedron 0.157 ± 0.0015 s 0.155 ± 0.0013 s 1.01 ± 0.012
Specializations/Scalar GaussLegendre/Triangle 0.603 ± 0.0079 ms 0.715 ± 0.019 ms 0.843 ± 0.025
time_to_load 1.44 ± 0.018 s 1.43 ± 0.0011 s 1.01 ± 0.012
Memory benchmarks
main eb7bf18... main / eb7bf18...
Differentials/Differential 3 allocs: 0.0938 kB 3 allocs: 0.0938 kB 1
Differentials/Jacobian 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Segment/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar HAdaptiveCubature 7 allocs: 0.492 kB 7 allocs: 0.492 kB 1
Integrals/Segment/Vector GaussKronrod 0.063 k allocs: 4.88 kB 0.063 k allocs: 4.88 kB 1
Integrals/Segment/Vector GaussLegendre 0.606 k allocs: 0.04 MB 0.606 k allocs: 0.04 MB 1
Integrals/Segment/Vector HAdaptiveCubature 0.085 k allocs: 6.75 kB 0.085 k allocs: 6.75 kB 1
Integrals/Sphere/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Sphere/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Sphere/Scalar HAdaptiveCubature 7 allocs: 0.648 kB 7 allocs: 0.648 kB 1
Integrals/Sphere/Vector GaussKronrod 0.063 k allocs: 4.88 kB 0.063 k allocs: 4.88 kB 1
Integrals/Sphere/Vector GaussLegendre 0.06 M allocs: 3.97 MB 0.06 M allocs: 3.97 MB 1
Integrals/Sphere/Vector HAdaptiveCubature 1.42 k allocs: 0.108 MB 1.42 k allocs: 0.108 MB 1
Rules/GaussLegendre 7 allocs: 0.0325 MB 7 allocs: 0.0325 MB 1
Specializations/Scalar GaussLegendre/BezierCurve 23 allocs: 0.75 kB 23 allocs: 0.75 kB 1
Specializations/Scalar GaussLegendre/Line 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Plane 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
Specializations/Scalar GaussLegendre/Ray 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Rope 0.068 k allocs: 1.62 kB 0.068 k allocs: 1.62 kB 1
Specializations/Scalar GaussLegendre/Tetrahedron 3 M allocs: 0.179 GB 3 M allocs: 0.179 GB 1
Specializations/Scalar GaussLegendre/Triangle 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@mikeingold
Copy link
Collaborator Author

Weird. I had to re-run a testing CI the other day because the Coveralls API sent an "under heavy load" response, and now we're getting "internal server error", but

https://status.coveralls.io/

doesn't currently indicate any issues.

@JoshuaLampert
Copy link
Member

I have noticed broken coveralls badges in the READMEs of different repos. It's also broken here: https://coveralls.io/github/JuliaGeometry/MeshIntegrals.jl?branch=main. So this looks like a temporary issue with coveralls.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Aug 14, 2025

Now, status.coveralls.io reports an outage. Edit: ...which seems to be fixed now.

@mikeingold
Copy link
Collaborator Author

Looks like it's back up and functional again.

@mikeingold mikeingold marked this pull request as ready for review August 14, 2025 18:56
@mikeingold mikeingold merged commit cc67c3a into main Aug 14, 2025
12 checks passed
@mikeingold mikeingold deleted the compat branch August 14, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants