Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the Meshes package from 0.53, 0.54, 0.55 to 0.53, 0.54, 0.55, 0.56 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@mikeingold mikeingold force-pushed the compathelper/new_version/2025-12-11-01-13-04-903-02772304828 branch from b002c38 to df11b64 Compare December 11, 2025 01:13
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 11, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main fdd0f61... main / fdd0f61...
Differentials/Differential 0.205 ± 0.016 μs 0.205 ± 0.0011 μs 1 ± 0.078
Differentials/Jacobian 0.17 ± 0.013 μs 0.158 ± 0.013 μs 1.08 ± 0.12
Integrals/Segment/Scalar GaussKronrod 0.582 ± 0.049 μs 0.631 ± 0.02 μs 0.922 ± 0.083
Integrals/Segment/Scalar GaussLegendre 1.67 ± 0.011 μs 1.69 ± 0.01 μs 0.988 ± 0.0087
Integrals/Segment/Scalar HAdaptiveCubature 0.821 ± 0.061 μs 0.821 ± 0.051 μs 1 ± 0.097
Integrals/Segment/Vector GaussKronrod 0.651 ± 0.01 μs 0.651 ± 0.05 μs 1 ± 0.078
Integrals/Segment/Vector GaussLegendre 5.2 ± 0.21 μs 4.57 ± 0.23 μs 1.14 ± 0.073
Integrals/Segment/Vector HAdaptiveCubature 0.871 ± 0.03 μs 0.862 ± 0.06 μs 1.01 ± 0.078
Integrals/Sphere/Scalar GaussKronrod 1.11 ± 0.09 μs 1.22 ± 0.02 μs 0.91 ± 0.075
Integrals/Sphere/Scalar GaussLegendre 1.88 ± 0.085 ms 1.87 ± 0.12 ms 1.01 ± 0.08
Integrals/Sphere/Scalar HAdaptiveCubature 0.0478 ± 0.00013 ms 0.048 ± 0.0037 ms 0.996 ± 0.077
Integrals/Sphere/Vector GaussKronrod 1.14 ± 0.091 μs 1.23 ± 0.1 μs 0.927 ± 0.11
Integrals/Sphere/Vector GaussLegendre 2.02 ± 0.051 ms 2.01 ± 0.12 ms 1.01 ± 0.065
Integrals/Sphere/Vector HAdaptiveCubature 0.0492 ± 0.00016 ms 0.0495 ± 0.0039 ms 0.995 ± 0.078
Rules/GaussLegendre 20.7 ± 1.7 μs 21.3 ± 1.3 μs 0.975 ± 0.097
Specializations/Scalar GaussLegendre/BezierCurve 0.244 ± 0.0075 ms 0.243 ± 0.02 ms 1 ± 0.087
Specializations/Scalar GaussLegendre/Line 6.93 ± 0.051 μs 6.38 ± 0.5 μs 1.09 ± 0.086
Specializations/Scalar GaussLegendre/Plane 0.78 ± 0.061 ms 0.779 ± 0.061 ms 1 ± 0.11
Specializations/Scalar GaussLegendre/Ray 5.44 ± 0.43 μs 5.99 ± 0.06 μs 0.908 ± 0.073
Specializations/Scalar GaussLegendre/Rope 0.0511 ± 0.004 ms 0.0511 ± 0.0038 ms 0.999 ± 0.11
Specializations/Scalar GaussLegendre/Tetrahedron 0.153 ± 0.003 s 0.151 ± 0.0039 s 1.01 ± 0.033
Specializations/Scalar GaussLegendre/Triangle 0.68 ± 0.014 ms 0.677 ± 0.046 ms 1.01 ± 0.072
time_to_load 1.44 ± 0.03 s 1.45 ± 0.016 s 0.996 ± 0.023
Memory benchmarks
main fdd0f61... main / fdd0f61...
Differentials/Differential 3 allocs: 0.0938 kB 3 allocs: 0.0938 kB 1
Differentials/Jacobian 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Segment/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar HAdaptiveCubature 7 allocs: 0.492 kB 7 allocs: 0.492 kB 1
Integrals/Segment/Vector GaussKronrod 2 allocs: 0.0781 kB 2 allocs: 0.0781 kB 1
Integrals/Segment/Vector GaussLegendre 0.307 k allocs: 12.8 kB 0.307 k allocs: 12.8 kB 1
Integrals/Segment/Vector HAdaptiveCubature 6 allocs: 0.688 kB 6 allocs: 0.688 kB 1
Integrals/Sphere/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Sphere/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Sphere/Scalar HAdaptiveCubature 7 allocs: 0.648 kB 7 allocs: 0.648 kB 1
Integrals/Sphere/Vector GaussKronrod 2 allocs: 0.0781 kB 2 allocs: 0.0781 kB 1
Integrals/Sphere/Vector GaussLegendre 30 k allocs: 1.22 MB 30 k allocs: 1.22 MB 1
Integrals/Sphere/Vector HAdaptiveCubature 6 allocs: 0.812 kB 6 allocs: 0.812 kB 1
Rules/GaussLegendre 7 allocs: 0.0325 MB 7 allocs: 0.0325 MB 1
Specializations/Scalar GaussLegendre/BezierCurve 23 allocs: 0.75 kB 23 allocs: 0.75 kB 1
Specializations/Scalar GaussLegendre/Line 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Plane 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
Specializations/Scalar GaussLegendre/Ray 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Rope 0.068 k allocs: 1.62 kB 0.068 k allocs: 1.62 kB 1
Specializations/Scalar GaussLegendre/Tetrahedron 3 M allocs: 0.179 GB 3 M allocs: 0.179 GB 1
Specializations/Scalar GaussLegendre/Triangle 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@JoshuaLampert
Copy link
Member

@juliohm, our tests fail with the update to Meshes.jl v0.56. What would be the equivalent to achieve the following under v0.56:

hexahedron = Hexahedron(discretize(box).vertices...)

This was possible in pre-v0.55 version, but fails on v0.56 with:

ERROR: LoadError: type RegularGrid has no field vertices

see https://github.com/JuliaGeometry/MeshIntegrals.jl/actions/runs/20127961579/job/57762047588?pr=214#step:7:224

@juliohm
Copy link
Member

juliohm commented Dec 11, 2025

Hi @JoshuaLampert , you can use hexa = convert(Hexahedron, box). I recommend replacing these internal field accesses by public API calls. Please feel free to ping me if there are other similar instances.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Dec 11, 2025

Thanks @juliohm. Just in the same moment you commented I replaced the access of the internal field by using the function call vertices instead. But convert(Hexahedron, box) sounds even better.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (92def00) to head (fdd0f61).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          191       191           
=========================================
  Hits           191       191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
Copy link
Member

Looks like this was the only instance 👍

@JoshuaLampert JoshuaLampert merged commit 098ae39 into main Dec 11, 2025
12 checks passed
@JoshuaLampert JoshuaLampert deleted the compathelper/new_version/2025-12-11-01-13-04-903-02772304828 branch December 11, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants