Remove Ring inner check (#1077)

Author: juliohm

src/geometries/polytopes.jl

@@ -177,7 +177,7 @@ const Polygon = Polytope{2}
     ≗(polygon₁, polygon₂)
 
 Tells whether or not the `polygon₁` and `polygon₂`
-are equal up to circular shifts.
+are equal regardless of circular shifts.
 """
 function ≗(p₁::Polygon, p₂::Polygon)
   rings₁ = rings(p₁)

src/geometries/polytopes/ring.jl

@@ -11,20 +11,8 @@ See also [`Chain`](@ref) and [`Rope`](@ref).
 """
 struct Ring{M<:Manifold,C<:CRS,V<:CircularVector{Point{M,C}}} <: Chain{M,C}
   vertices::V
-
-  function Ring{M,C,V}(vertices) where {M<:Manifold,C<:CRS,V<:CircularVector{Point{M,C}}}
-    if first(vertices) == last(vertices) && length(vertices) ≥ 2
-      throw(ArgumentError("""
-      First and last vertices of `Ring` constructor must be different
-      in the latest version of Meshes.jl. The type itself now holds
-      this connectivity information.
-      """))
-    end
-    new(vertices)
-  end
 end
 
-Ring(vertices::CircularVector{Point{M,C}}) where {M<:Manifold,C<:CRS} = Ring{M,C,typeof(vertices)}(vertices)
 Ring(vertices::Tuple...) = Ring([Point(v) for v in vertices])
 Ring(vertices::P...) where {P<:Point} = Ring(collect(vertices))
 Ring(vertices::AbstractVector{<:Tuple}) = Ring(Point.(vertices))
@@ -38,7 +26,7 @@ nvertices(r::Ring) = length(r.vertices)
     ≗(ring₁, ring₂)
 
 Tells whether or not the `ring₁` and `ring₂`
-are equal up to circular shifts.
+are equal regardless of circular shifts.
 """
 function ≗(r₁::Ring, r₂::Ring)
   n = length(r₁.vertices)

test/polytopes.jl

@@ -178,10 +178,6 @@ end
   c = Ring(cart.([(0, 0), (1, 0), (1, 1), (0, 1)]))
   @test isnothing(boundary(c))
 
-  # should not repeat the first vertex manually
-  @test_throws ArgumentError Ring(cart.([(0, 0), (0, 0)]))
-  @test_throws ArgumentError Ring(cart.([(0, 0), (1, 0), (1, 1), (0, 0)]))
-
   # degenerate rings with 1 or 2 vertices are allowed
   r = Ring(cart.([(0, 0)]))
   @test isclosed(r)
@@ -657,10 +653,6 @@ end
     inner
     ├─ Ring((x: 0.2 m, y: 0.2 m), ..., (x: 0.4 m, y: 0.2 m))
     └─ Ring((x: 0.6 m, y: 0.2 m), ..., (x: 0.8 m, y: 0.2 m))"""
-
-  # should not repeat the first vertex manually
-  @test_throws ArgumentError PolyArea(cart.([(0, 0), (0, 0)]))
-  @test_throws ArgumentError PolyArea(cart.([(0, 0), (1, 0), (1, 1), (0, 0)]))
 end
 
 @testitem "Polyhedra" setup = [Setup] begin