Widen vector type in GeometrySet (#1256)

* Widen vector type in GeometrySet

* Apply Copilot suggestion

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

Author: juliohm

src/domains/sets.jl

@@ -19,8 +19,8 @@ julia> GeometrySet([Ball((0.0, 0.0)), Ball((1.0, 1.0))])
 
 Geometries with different CRS will be projected to the CRS of the first geometry.
 """
-struct GeometrySet{M<:Manifold,C<:CRS,G<:Geometry{M,C}} <: Domain{M,C}
-  geoms::Vector{G}
+struct GeometrySet{M<:Manifold,C<:CRS,G<:Geometry{M,C},V<:AbstractVector{G}} <: Domain{M,C}
+  geoms::V
 end
 
 # constructor with iterator of geometries
@@ -50,7 +50,7 @@ Base.vcat(d1::Domain, d2::GeometrySet) = GeometrySet(vcat(collect(d1), d2.geoms)
 # SPECIAL CASE: POINT SET
 # ------------------------
 
-const PointSet{M<:Manifold,C<:CRS} = GeometrySet{M,C,Point{M,C}}
+const PointSet{M<:Manifold,C<:CRS,V<:AbstractVector{Point{M,C}}} = GeometrySet{M,C,Point{M,C},V}
 
 """
     PointSet(points)
@@ -68,7 +68,7 @@ julia> PointSet([(1,2,3), (4,5,6)])
 julia> PointSet((1,2,3), (4,5,6))
 ```
 """
-PointSet(points::AbstractVector{Point{M,C}}) where {M<:Manifold,C<:CRS} = PointSet{M,C}(points)
+PointSet(points::AbstractVector{Point{M,C}}) where {M<:Manifold,C<:CRS} = PointSet{M,C,typeof(points)}(points)
 PointSet(points::Vararg{P}) where {P<:Point} = PointSet(collect(points))
 PointSet(coords::AbstractVector{TP}) where {TP<:Tuple} = PointSet(Point.(coords))
 PointSet(coords::Vararg{TP}) where {TP<:Tuple} = PointSet(collect(coords))

test/sets.jl

@@ -23,6 +23,14 @@
   push!(geoms, Segment(cart(1, 1), cart(0, 0)))
   gset = GeometrySet(geoms)
   @test eltype(gset) <: Segment
+  @test nelements(gset) == 3
+
+  # construction with custom vectors of geometries
+  # https://github.com/JuliaEarth/GeoStats.jl/issues/551
+  geoms = @SVector [cart(0, 0), cart(1, 1)]
+  gset = GeometrySet(geoms)
+  @test eltype(gset) <: Point
+  @test nelements(gset) == 2
 
   # different CRS
   s = Segment(latlon(0, 0), latlon(1, 1))