Fix Rotate of Ellipsoid (#1030)

* Fix Rotate of Ellipsoid

* Improve test

Author: juliohm

src/transforms/rotate.jl

@@ -71,7 +71,7 @@ applycoord(t::Rotate, v::Vec) = urotapply(t.rot, v)
 
 applycoord(t::Rotate, b::Box) = TransformedGeometry(b, t)
 
-applycoord(t::Rotate, e::Ellipsoid) = Ellipsoid(radii(e), center(e), t.rot * rotation(e))
+applycoord(t::Rotate, e::Ellipsoid) = Ellipsoid(radii(e), applycoord(t, center(e)), t.rot * rotation(e))
 
 applycoord(t::Rotate, g::CartesianGrid) = TransformedGrid(g, t)
 

test/primitives.jl

@@ -701,10 +701,6 @@ end
   equaltest(e)
   isapproxtest(e)
 
-  e = Ellipsoid((T(3), T(2), T(1)))
-  R = RotXYZ(T(π / 4), T(π / 5), T(π / 3))
-  @test rotation(e |> Rotate(R)) == R
-
   e = Ellipsoid((T(3), T(2), T(1)))
   @test sprint(show, e) ==
         "Ellipsoid(radii: (3.0 m, 2.0 m, 1.0 m), center: (x: 0.0 m, y: 0.0 m, z: 0.0 m), rotation: UniformScaling{Bool}(true))"

test/transforms.jl

@@ -136,6 +136,17 @@
   @test r ≈ Cylinder(cart(0, 0, 0), cart(1, 0, 0))
   @test TB.revert(f, r, c) ≈ g
 
+  # ----------
+  # ELLIPSOID
+  # ----------
+
+  R = RotXYZ(T(π / 4), T(π / 5), T(π / 3))
+  f = Rotate(R)
+  g = Ellipsoid((T(3), T(2), T(1)), (T(1), T(1), T(1)))
+  r, c = TB.apply(f, g)
+  @test center(r) == center(g) |> Rotate(R)
+  @test rotation(r) == R
+
   # ---------
   # POINTSET
   # ---------