Fix paramdim of primitives over ellipsoid (#1001)

Author: juliohm

src/geometries/primitives/ball.jl

@@ -23,7 +23,9 @@ Ball(center::Point) = Ball(center, oneunit(lentype(center)))
 
 Ball(center::Tuple) = Ball(Point(center))
 
-paramdim(B::Type{<:Ball}) = embeddim(B)
+paramdim(::Type{<:Ball{𝔼{Dim}}}) where {Dim} = Dim
+
+paramdim(::Type{<:Ball{🌐}}) = 2
 
 center(b::Ball) = b.center
 

src/geometries/primitives/box.jl

@@ -41,7 +41,9 @@ Box(min::Point{M,C}, max::Point{M,C}) where {M<:Manifold,C<:CRS} = Box{M,C}(min,
 
 Box(min::Tuple, max::Tuple) = Box(Point(min), Point(max))
 
-paramdim(B::Type{<:Box}) = embeddim(B)
+paramdim(::Type{<:Box{𝔼{Dim}}}) where {Dim} = Dim
+
+paramdim(::Type{<:Box{🌐}}) = 2
 
 Base.minimum(b::Box) = b.min
 

src/geometries/primitives/sphere.jl

@@ -60,7 +60,9 @@ end
 
 Sphere(p1::Tuple, p2::Tuple, p3::Tuple, p4::Tuple) = Sphere(Point(p1), Point(p2), Point(p3), Point(p4))
 
-paramdim(S::Type{<:Sphere}) = embeddim(S) - 1
+paramdim(::Type{<:Sphere{𝔼{Dim}}}) where {Dim} = Dim - 1
+
+paramdim(::Type{<:Sphere{🌐}}) = 1
 
 center(s::Sphere) = s.center
 

test/primitives.jl

@@ -399,6 +399,10 @@
     @test maximum(b) == cart(1, 1, 1)
     @test extrema(b) == (cart(0, 0, 0), cart(1, 1, 1))
 
+    b = Box(latlon(0, 0), latlon(45, 90))
+    @test embeddim(b) == 3
+    @test paramdim(b) == 2
+
     b = Box(cart(0, 0), cart(1, 1))
     equaltest(b)
     isapproxtest(b)
@@ -512,6 +516,10 @@
     @test Meshes.center(b) == cart(1, 2, 3)
     @test radius(b) == T(5) * u"m"
 
+    b = Ball(latlon(0, 0), T(5))
+    @test embeddim(b) == 3
+    @test paramdim(b) == 2
+
     b = Ball(cart(0, 0), T(1))
     equaltest(b)
     isapproxtest(b)
@@ -589,6 +597,10 @@
     @test isnothing(boundary(s))
     @test perimeter(s) == zero(ℳ)
 
+    s = Sphere(latlon(0, 0), T(1))
+    @test embeddim(s) == 3
+    @test paramdim(s) == 1
+
     s = Sphere(cart(0, 0), T(1))
     equaltest(s)
     isapproxtest(s)