Handle different CRS and length units in sideof (#1014)

* add length convert to sideof

* use Proj

* Update src/sideof.jl

Co-authored-by: Júlio Hoffimann <[email protected]>

* fix test for sideof with different units

* More adjustments

* Update compat

* Refactor withcrs

* Revert changes

---------

Co-authored-by: Kyle Beggs <[email protected]>
Co-authored-by: Júlio Hoffimann <[email protected]>
Co-authored-by: Elias Carvalho <[email protected]>

Author: 4 people

Project.toml

@@ -31,7 +31,7 @@ MeshesMakieExt = "Makie"
 Bessels = "0.2"
 CircularArrays = "1.3"
 Colorfy = "0.1"
-CoordRefSystems = "0.10"
+CoordRefSystems = "0.11"
 DelaunayTriangulation = "1.0"
 Distances = "0.10"
 LinearAlgebra = "1.9"

src/sideof.jl

@@ -58,10 +58,11 @@ Possible results are `IN`, `OUT` or `ON` the `ring`.
 """
 function sideof(point::Point, ring::Ring)
   assertion(CoordRefSystems.ncoords(crs(point)) == 2, "points must have 2 coordinates")
+  point′ = point |> Proj(crs(ring))
   if nvertices(ring) ≤ 1000 || Threads.nthreads() == 1
-    _sideofserial(point, ring)
+    _sideofserial(point′, ring)
   else
-    _sideofthreads(point, ring)
+    _sideofthreads(point′, ring)
   end
 end
 

test/sideof.jl

@@ -15,6 +15,13 @@
   pts = [p1, p2, p3]
   @test sideof(pts, c) == [IN, OUT, ON]
 
+  c′ = c |> LengthUnit(Unitful.mm)
+  @test sideof(p1, c′) == IN
+  @test sideof(p2, c′) == OUT
+  @test sideof(p3, c′) == ON
+  pts = [p1, p2, p3]
+  @test sideof(pts, c′) == [IN, OUT, ON]
+
   p1, p2, p3 = merc(0.5, 0.5), merc(1.5, 0.5), merc(1, 1)
   c = Ring([merc(0, 0), merc(1, 0), merc(1, 1), merc(0, 1)])
   @test sideof(p1, c) == IN