Skip to content

Commit 53da502

Browse files
committed
[test] fix dc test
1 parent 7570ab7 commit 53da502

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/dual_contours.jl

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,7 @@ function dual_contours(f::Function,
5858
end
5959
b = [ dot(d[1],d[2]) for d in h_data ]
6060

61-
# use SVD for pseudo inverse
62-
# F = svd(A, full=true)
63-
# S = zeros(size(A))
64-
# for i = 1:length(F.S)
65-
# S[i,i] = 1/(F.S[i])
66-
# end
67-
# ainv = F.V*S*F.U'
68-
69-
#compute the vertex from SVD
61+
#compute the vertex using pseudo inverse
7062
v = pinv(A)*b
7163

7264
#Throw out failed solutions

test/runtests.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,8 @@ using LinearAlgebra: dot, norm
146146
sphere(v) = sqrt(sum(dot(v,v))) - 1 # sphere
147147

148148
m = SimpleMesh(sphere, HyperRectangle(Vec(-1,-1,-1.),Vec(2,2,2.)), (50,50,50), DualContours())
149-
# the current LLS approach in DualContours is not numerically robust and has varied outputs
150-
@test_broken length(vertices(m)) == 11754
151-
@test_broken length(faces(m)) == 51186
149+
@test length(vertices(m)) == 11754
150+
@test length(faces(m)) == 51186
152151
end
153152

154153
@testset "AbstractMeshingAlgorithm interface" begin

0 commit comments

Comments
 (0)