Skip to content

Commit 1a2d4c2

Browse files
authored
Remove deprecated imag and linpol (#101)
* remove deprecated imag and linpol * remove tests for linpol
1 parent eebbf5b commit 1a2d4c2

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

src/Quaternion.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ quat(s, a) = Quaternion(s, a)
3232
real(::Type{Quaternion{T}}) where {T} = T
3333
real(q::Quaternion) = q.s
3434
imag_part(q::Quaternion) = (q.v1, q.v2, q.v3)
35-
@deprecate imag(q::Quaternion) collect(imag_part(q)) false
3635

3736
(/)(q::Quaternion, x::Real) = Quaternion(q.s / x, q.v1 / x, q.v2 / x, q.v3 / x)
3837
(*)(q::Quaternion, x::Real) = Quaternion(q.s * x, q.v1 * x, q.v2 * x, q.v3 * x)
@@ -358,8 +357,6 @@ function slerp(qa::Quaternion{Ta}, qb::Quaternion{Tb}, t::T) where {Ta, Tb, T}
358357
return slerp(Quaternion{S}(qa),Quaternion{S}(qb),S(t))
359358
end
360359

361-
Base.@deprecate linpol(p::Quaternion, q::Quaternion, t::Real) slerp(p, q, t)
362-
363360
function sylvester(a::Quaternion{T}, b::Quaternion{T}, c::Quaternion{T}) where {T<:Real}
364361
isreal(a) && return sylvester(real(a), b, c)
365362
isreal(b) && return sylvester(a, real(b), c)

test/Quaternion.jl

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ Base.:(/)(a::MyReal, b::Real) = a.val / b
178178
qnorm = normalize(q)
179179
@test real(q) === q.s
180180
@test_throws MethodError imag(q)
181-
@test @test_deprecated(Quaternions.imag(q)) == [q.v1, q.v2, q.v3]
182181
@test imag_part(q) === (q.v1, q.v2, q.v3)
183182
@test conj(q) === Quaternion(q.s, -q.v1, -q.v2, -q.v3, q.norm)
184183
@test conj(qnorm) === Quaternion(qnorm.s, -qnorm.v1, -qnorm.v2, -qnorm.v3, true)
@@ -592,7 +591,7 @@ Base.:(/)(a::MyReal, b::Real) = a.val / b
592591
end
593592
end
594593

595-
@testset "slerp/linpol" begin
594+
@testset "slerp" begin
596595
@testset "q1=1" begin
597596
a = quat(1, 0, 0, 0.0, true)
598597
b = quat(0, 0, 0, 1.0, true)
@@ -617,9 +616,6 @@ Base.:(/)(a::MyReal, b::Real) = a.val / b
617616
@test slerp(q1, q2, 0.5) qrotation(ax, 0.5 * θ)
618617
@test slerp(q1, q1, 0.5) q1
619618
@test slerp(q1, qsmall, 0.5) sign((q1 + qsmall) / 2)
620-
@test linpol(q1, q2, 0.5) qrotation(ax, 0.5 * θ)
621-
@test linpol(q1, q1, 0.5) q1
622-
@test linpol(q1, qsmall, 0.5) sign((q1 + qsmall) / 2)
623619
end
624620
end
625621

@@ -629,7 +625,6 @@ Base.:(/)(a::MyReal, b::Real) = a.val / b
629625
(s, t) = s * t * inv(s)
630626
t = rand()
631627
@test q slerp(q1, q2, t) slerp(q q1, q q2, t)
632-
@test q linpol(q1, q2, t) linpol(q q1, q q2, t)
633628
end
634629
end
635630

@@ -646,10 +641,6 @@ Base.:(/)(a::MyReal, b::Real) = a.val / b
646641
@test_throws DomainError slerp(quat(0),quat(1),0)
647642
end
648643

649-
@testset "Deprecated warning" begin
650-
@test_deprecated linpol(quat(1),quat(1),0)
651-
end
652-
653644
@testset "Normalizing input quaternions" begin
654645
for _ in 1:100
655646
q1 = randn(QuaternionF64)

0 commit comments

Comments
 (0)