Relax input type constraint to enable eltype promotion. (#230)

* Enable auto promote.

* add test

* Use `SArray{Tuple{N,N}}` to throw a `DimensionMismatch`

Author: N5N3

src/core_types.jl

@@ -77,25 +77,25 @@ RotMatrix(x::SMatrix{N,N,T,L}) where {N,T,L} = RotMatrix{N,T,L}(x)
 Base.zero(::Type{RotMatrix}) = error("The dimension of rotation is not specified.")
 
 # These functions (plus size) are enough to satisfy the entire StaticArrays interface:
-@inline function RotMatrix(t::NTuple{L}) where L
-    n = sqrt(L)
+@inline function RotMatrix(t::Tuple)
+    n = sqrt(length(t))
     if !isinteger(n)
         throw(DimensionMismatch("The length of input tuple $(t) must be square number."))
     end
     N = Int(n)
     RotMatrix(SMatrix{N,N}(t))
 end
-@inline (::Type{RotMatrix{N}})(t::NTuple) where N = RotMatrix(SMatrix{N,N}(t))
-@inline RotMatrix{N,T}(t::NTuple) where {N,T} = RotMatrix(SMatrix{N,N,T}(t))
-@inline RotMatrix{N,T,L}(t::NTuple{L}) where {N,T,L} = RotMatrix(SMatrix{N,N,T}(t))
+@inline (::Type{RotMatrix{N}})(t::Tuple) where N = RotMatrix(SArray{Tuple{N,N}}(t))
+@inline RotMatrix{N,T}(t::Tuple) where {N,T} = RotMatrix(SArray{Tuple{N,N},T}(t))
+@inline RotMatrix{N,T,L}(t::Tuple) where {N,T,L} = RotMatrix(SArray{Tuple{N,N},T}(t))
 
 # Create aliases RotMatrix2{T} = RotMatrix{2,T,4} and RotMatrix3{T} = RotMatrix{3,T,9}
 for N = 2:3
     L = N*N
     RotMatrixN = Symbol(:RotMatrix, N)
     @eval begin
         const $RotMatrixN{T} = RotMatrix{$N, T, $L}
-        @inline $RotMatrixN(t::NTuple{$L}) = RotMatrix(SMatrix{$N,$N}(t))
+        @inline $RotMatrixN(t::Tuple) = RotMatrix(SArray{Tuple{$N,$N}}(t))
     end
 end
 
@@ -152,7 +152,7 @@ params(r::Angle2d) = SVector{1}(r.theta)
 
 Angle2d(r::Rotation{2}) = Angle2d(rotation_angle(r))
 Angle2d{T}(r::Rotation{2}) where {T} = Angle2d{T}(rotation_angle(r))
-@inline (::Type{R})(t::NTuple{4}) where R<:Angle2d = convert(R, RotMatrix(t))
+@inline (::Type{R})(t::Tuple) where R<:Angle2d = convert(R, RotMatrix2(t))
 
 Base.one(::Type{A}) where {A<: Angle2d} = A(0)
 

test/2d.jl

@@ -11,7 +11,10 @@ using Unitful
         @test RotMatrix((1,0,0,1)) == RotMatrix(@SMatrix [1 0;0 1]) == one(SMatrix{2,2})
         @test Angle2d((1,0,0,1))   == RotMatrix(@SMatrix [1 0;0 1]) == one(SMatrix{2,2})
         @test RotMatrix((1,0,0,1)) isa RotMatrix2{Int}
+        @test RotMatrix((1.,0,0,1)) isa RotMatrix2{Float64}
+        @test RotMatrix2((1f0,0,0,1)) isa RotMatrix2{Float32}
         @test Angle2d((1,0,0,1))   isa Angle2d{Float64}
+        @test Angle2d((1f0,0,0,1))   isa Angle2d{Float32}
         @test RotMatrix{2,Float32}((1,0,0,1)) isa RotMatrix2{Float32}
         @test Angle2d{Float32}((1,0,0,1))   isa Angle2d{Float32}
         @test_throws DimensionMismatch RotMatrix((1,0,0,1,0))