Skip to content

Commit b5735fe

Browse files
committed
Fix theme undefined in dialog
1 parent 0a91fe6 commit b5735fe

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

src/input.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ julia> ui[]
6969
0-element Array{String,1}
7070
```
7171
"""
72-
opendialog(::WidgetTheme; value = String[], label = "Open", icon = "far fa-folder-open", kwargs...) =
73-
dialog(js"showOpenDialog"; value = value, label = label, icon = icon, kwargs...)
72+
opendialog(theme::WidgetTheme; value = String[], label = "Open", icon = "far fa-folder-open", kwargs...) =
73+
dialog(theme, js"showOpenDialog"; value = value, label = label, icon = icon, kwargs...)
7474

7575
"""
7676
`savedialog(; value = String[], label = "Open", icon = "far fa-folder-open", options...)`
@@ -88,10 +88,10 @@ julia> ui[]
8888
""
8989
```
9090
"""
91-
savedialog(::WidgetTheme; value = "", label = "Save", icon = "far fa-save", kwargs...) =
92-
dialog(js"showSaveDialog"; value = value, label = label, icon = icon, kwargs...)
91+
savedialog(theme::WidgetTheme; value = "", label = "Save", icon = "far fa-save", kwargs...) =
92+
dialog(theme, js"showSaveDialog"; value = value, label = label, icon = icon, kwargs...)
9393

94-
function dialog(dialogtype; value, className = "", label = "dialog", icon = nothing, options...)
94+
function dialog(theme::WidgetTheme, dialogtype; value, className = "", label = "dialog", icon = nothing, options...)
9595
(value isa AbstractObservable) || (value = Observable(value))
9696
scp = Scope()
9797
setobservable!(scp, "output", value)

test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ using Test
1010
include("test_observables.jl")
1111
include("test_theme.jl")
1212
include("test_deps.jl")
13+
include("test_dialog.jl")

test/test_dialog.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
using InteractBase
2+
using Test
3+
4+
@testset "Dialog" begin
5+
@test InteractBase.opendialog() isa Widget
6+
@test InteractBase.savedialog() isa Widget
7+
end

0 commit comments

Comments
 (0)