Merge pull request #512 from mosullivan93/threadsafety

Use thread-safe conditions for connection pool

Author: shashi

src/connection.jl

@@ -20,7 +20,7 @@ are automatically removed from the pool.
 struct ConnectionPool
     outbox::Channel
     connections::Set{AbstractConnection}
-    condition::Condition
+    condition::Threads.Condition
 end
 
 function ConnectionPool(
@@ -30,7 +30,7 @@ function ConnectionPool(
     pool = ConnectionPool(
         outbox,
         connections,
-        Condition(),
+        Threads.Condition(),
     )
 
     # Catch errors here, otherwise they are lost to the void.
@@ -68,12 +68,24 @@ current task until that is the case. Also processes incoming connections.
 """
 function ensure_connection(pool::ConnectionPool)
     if isempty(pool.connections)
-        wait(pool.condition)
+        lock(pool.condition)
+        try
+            wait(pool.condition)
+        finally
+            unlock(pool.condition)
+        end
     end
 end
 
 Base.wait(pool::ConnectionPool) = ensure_connection(pool)
-Base.notify(pool::ConnectionPool) = notify(pool.condition)
+function Base.notify(pool::ConnectionPool)
+    lock(pool.condition)
+    try
+        notify(pool.condition)
+    finally
+        unlock(pool.condition)
+    end
+end
 
 """
     process_messages(pool)

test/blink-tests.jl

@@ -3,10 +3,6 @@ using Blink
 using Observables
 using Test
 
-notinstalled = !AtomShell.isinstalled()
-
-notinstalled && AtomShell.install()
-
 """
 Execute function f() with a timeout of `timeout` seconds. Returns the
 result of f() or `nothing` in the case of a timeout.
@@ -146,5 +142,3 @@ w = open_window()
     body!(w, ExampleRenderableType())
     @test example_renderable_was_rendered
 end
-
-notinstalled && AtomShell.uninstall()