Skip to content

Commit dfcffe1

Browse files
committed
rely less on Requires.jl
1 parent 91156f8 commit dfcffe1

File tree

3 files changed

+7
-70
lines changed

3 files changed

+7
-70
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Observables = "510215fc-4207-5dde-b226-833fc4488ee2"
99
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
1010
AssetRegistry = "bf4720bc-e11a-5d0c-854e-bdca1663c893"
1111
UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
12+
Mux = "a975b10e-0019-58db-a62f-e48ff68538c9"
1213
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
1314
Widgets = "cc8bc4a8-27d6-5769-a93b-9d913e69aa62"
1415
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
@@ -25,7 +26,6 @@ Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
2526
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
2627
JSExpr = "97c1335a-c9c5-57fe-bc5d-ec35cebe8660"
2728
IJulia = "7073ff75-c697-5162-941a-fcdaad2a7d2a"
28-
Mux = "a975b10e-0019-58db-a62f-e48ff68538c9"
2929
Blink = "ad839575-38b3-5650-b840-f874b8c74a25"
3030
NBInclude = "0db19996-df87-5ea3-a455-e3a50d440464"
3131
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
@@ -42,4 +42,4 @@ WebSockets = "1.5.0"
4242
Requires = "0.4.4, 0.5, 1.0.0"
4343

4444
[targets]
45-
test = ["Blink", "Conda", "DataStructures", "Dates", "IJulia", "JSExpr", "Mux", "NBInclude", "Test"]
45+
test = ["Blink", "Conda", "DataStructures", "Dates", "IJulia", "JSExpr", "NBInclude", "Test"]

src/WebIO.jl

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import Widgets: node, AbstractWidget
99
using Logging
1010
using UUIDs
1111
using Base64
12+
using Mux
13+
using WebSockets
1214

1315
include("../deps/bundlepaths.jl")
1416

@@ -94,35 +96,16 @@ function prefetch_provider_file(basename)
9496
(file = filepath, code = code)
9597
end
9698

97-
provider_mux = prefetch_provider_file("mux.jl")
98-
provider_blink = prefetch_provider_file("blink.jl")
99+
include("providers/mux.jl")
100+
include("providers/generic_http.jl")
101+
99102
provider_ijulia = prefetch_provider_file("ijulia.jl")
100-
provider_generic_http = prefetch_provider_file("generic_http.jl")
101103

102104
function __init__()
103105
push!(Observables.addhandler_callbacks, WebIO.setup_comm)
104-
@require Mux="a975b10e-0019-58db-a62f-e48ff68538c9" begin
105-
include_string(@__MODULE__, provider_mux.code, provider_mux.file)
106-
end
107-
@require Blink="ad839575-38b3-5650-b840-f874b8c74a25" begin
108-
# The latest version of Blink defines their own WebIO integration
109-
# (after https://github.com/JunoLab/Blink.jl/pull/201).
110-
if isdefined(Blink.AtomShell, :initwebio!)
111-
return
112-
end
113-
Base.depwarn(
114-
"Please upgrade Blink for a smoother integration with WebIO.",
115-
:webio_blink_upgrade,
116-
)
117-
include_string(@__MODULE__, provider_blink.code, provider_blink.file)
118-
end
119106
@require IJulia="7073ff75-c697-5162-941a-fcdaad2a7d2a" begin
120107
include_string(@__MODULE__, provider_ijulia.code, provider_ijulia.file)
121108
end
122-
@require WebSockets="104b5d7c-a370-577a-8038-80a2059c5097" begin
123-
include_string(@__MODULE__, provider_generic_http.code, provider_generic_http.file)
124-
end
125-
126109
end
127110

128111
end # module

src/providers/blink.jl

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)