Add error message for unsupported values (#23)

* Add error message for unsupported values

* Apply suggestions

* Expand CI.yml config

---------

Co-authored-by: Júlio Hoffimann <[email protected]>

Author: eliascarv

.github/workflows/CI.yml

@@ -23,10 +23,12 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - '1'
           - '1.9'
+          - '1'
         os:
           - ubuntu-latest
+          - macos-latest
+          - windows-latest
         arch:
           - x64
     steps:

src/Colorfy.jl

@@ -163,6 +163,13 @@ end
 Function intended for developers that returns the mapped colors from the `colorfier` without the alphas. 
 Alphas are applied in the `Colorfy.colors` function.
 """
+function getcolors(colorfier::Colorfier)
+  throw(ArgumentError("""
+  Values of type `$(eltype(colorfier.values))` are not supported.
+  Please make sure your vector of colors has a concrete type.
+  """))
+end
+
 getcolors(colorfier::Colorfier{<:Values{Number}}) =
   get(colorscheme(colorfier), values(colorfier), colorrange(colorfier))
 

test/runtests.jl

@@ -73,6 +73,15 @@ using Test
     values = coloralpha.(colors, alphas)
     colorfier = Colorfier(values)
     @test Colorfy.colors(colorfier) == values
+
+    # error: unsupported values
+    values = [nothing, nothing, nothing]
+    colorfier = Colorfier(values)
+    @test_throws ArgumentError Colorfy.colors(colorfier)
+    values = Any[:red, :green, :blue] # vector with non-concrete eltype
+    alphas = rand(3)
+    colorfier = Colorfier(values; alphas)
+    @test_throws ArgumentError Colorfy.colors(colorfier)
   end
 
   @testset "colorfy" begin