Skip to content

Conversation

@juliohm
Copy link
Collaborator

@juliohm juliohm commented Dec 23, 2025

This specification is already supported by Makie.jl and other plotting ecosystems.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a33da71) to head (6a15537).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           97        98    +1     
=========================================
+ Hits            97        98    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for specifying color schemes as vectors of color strings, aligning with conventions used in Makie.jl and other plotting ecosystems. The implementation allows users to pass a vector like ["black", "white"] as a colorscheme parameter, which is automatically converted to a ColorScheme object.

Key Changes

  • Extended ascolorscheme function to accept AbstractVector of color strings
  • Updated documentation to use more generic "color scheme specification" terminology
  • Added tests verifying the new vector-based colorscheme functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Colorfy.jl Added new method for ascolorscheme to parse vector of color strings into ColorScheme objects; updated documentation to reflect broader colorscheme input options
test/runtests.jl Added tests validating that vector colorscheme specifications work correctly with two-color gradient

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@juliohm juliohm requested review from eliascarv and removed request for eliascarv December 23, 2025 12:14
@juliohm
Copy link
Collaborator Author

juliohm commented Dec 23, 2025

Sorry for pinging you @eliascarv. I believe the changes are simple enough and I don't want to bother you during the holiday break.

@juliohm juliohm merged commit 7a552e4 into main Dec 23, 2025
14 checks passed
@juliohm juliohm deleted the colorscheme-spec branch December 23, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants