reordered input args; best practice README, @eval func defs, optional parent

Author: bjarthur

README.md

@@ -475,7 +475,7 @@ Gtk.jl also supports GtkMessageDialog and provides several convenience functions
 
 ```
 info_dialog("Julia rocks!")
-ask_dialog('Do you like chocolate ice cream?) && println("That's my favorite too.")
-warn_dialog("Oops!... I did it again", parent=win)
+ask_dialog('Do you like chocolate ice cream?, "I like it", "Not at all") && println("That's my favorite too.")
+warn_dialog("Oops!... I did it again", win)
 
 ```

src/Gtk.jl

@@ -37,7 +37,6 @@ include("base.jl")
 include("gdk.jl")
 include("events.jl")
 include("container.jl")
-include("windows.jl")
 include("layout.jl")
 include("displays.jl")
 include("lists.jl")
@@ -73,6 +72,8 @@ end
 const _ = GAccessor
 using .GConstants
 
+include("windows.jl")
+
 # Alternative Interface (`using Gtk.ShortNames`)
 module ShortNames
     using ..Gtk

src/selectors.jl

@@ -65,7 +65,7 @@ function makefilters(dlgp::GtkFileChooser, filters::Union(AbstractVector,Tuple))
     end
 end
 
-function open_dialog(title::String; parent = GtkNullContainer(), filters::Union(AbstractVector,Tuple) = ASCIIString[], multiple::Bool = false)
+function open_dialog(title::String, parent = GtkNullContainer(); filters::Union(AbstractVector,Tuple) = ASCIIString[], multiple::Bool = false)
     dlg = @GtkFileChooserDialog(title, parent, GConstants.GtkFileChooserAction.OPEN,
                                 "_Cancel", GConstants.GtkResponseType.CANCEL,
                                 "_Open",   GConstants.GtkResponseType.ACCEPT)
@@ -96,7 +96,7 @@ function open_dialog(title::String; parent = GtkNullContainer(), filters::Union(
     selection
 end
 
-function save_dialog(title::String; parent = GtkNullContainer(), filters::Union(AbstractVector,Tuple) = ASCIIString[])
+function save_dialog(title::String, parent = GtkNullContainer(); filters::Union(AbstractVector,Tuple) = ASCIIString[])
     dlg = @GtkFileChooserDialog(title, parent, GConstants.GtkFileChooserAction.SAVE,
                                 "_Cancel", GConstants.GtkResponseType.CANCEL,
                                 "_Save",   GConstants.GtkResponseType.ACCEPT)

src/windows.jl

@@ -46,44 +46,39 @@ end
 GtkAboutDialogLeaf() = GtkAboutDialogLeaf(
     ccall((:gtk_about_dialog_new,libgtk),Ptr{GObject},()))
 
-function GtkMessageDialogLeaf(parent::GtkContainer, flags::Integer, typ::Integer,
-        message::StringLike, buttons)
+function GtkMessageDialogLeaf(message::StringLike, buttons, flags::Integer, typ::Integer, parent = GtkNullContainer())
     w = GtkMessageDialogLeaf(ccall((:gtk_message_dialog_new,libgtk), Ptr{GObject},
         (Ptr{GObject},Cint,Cint,Cint,Ptr{Uint8}),
-        parent, flags, typ, GtkButtonsType.NONE, bytestring(message) ))
+        parent, flags, typ, GtkButtonsType.NONE, C_NULL))
+    setproperty!(w, :text, bytestring(message))
     for (k,v) in buttons
         push!(w, k, v)
     end
     w
 end
 
-function info_dialog(message::String; parent = GtkNullContainer())
-    dlg = @GtkMessageDialog(parent, GtkDialogFlags.DESTROY_WITH_PARENT,
-	    GtkMessageType.INFO, GtkButtonsType.CLOSE, message)
-    run(dlg)
-    destroy(dlg)
-end
+ask_dialog(message::String, parent = GtkNullContainer()) =
+        ask_dialog(message, "Yes", "No", parent)
 
-function ask_dialog(message::String, yes_text="Yes", no_text="No"; parent = GtkNullContainer())
-    dlg = @GtkMessageDialog(parent, GtkDialogFlags.DESTROY_WITH_PARENT,
-	    GtkMessageType.QUESTION, message, ((yes_text,1), (no_text,2)))
+function ask_dialog(message::String, yes_text, no_text, parent = GtkNullContainer())
+    dlg = @GtkMessageDialog(message, ((yes_text,1), (no_text,2)),
+            GtkDialogFlags.DESTROY_WITH_PARENT, GtkMessageType.QUESTION, parent)
     response = run(dlg)
     destroy(dlg)
     response == 1
 end
 
-function warn_dialog(message::String; parent = GtkNullContainer())
-    dlg = @GtkMessageDialog(parent, GtkDialogFlags.DESTROY_WITH_PARENT,
-	    GtkMessageType.WARNING, GtkButtonsType.CLOSE, message)
-    run(dlg)
-    destroy(dlg)
-end
-
-function error_dialog(message::String; parent = GtkNullContainer())
-    dlg = @GtkMessageDialog(parent, GtkDialogFlags.DESTROY_WITH_PARENT,
-	    GtkMessageType.ERROR, GtkButtonsType.CLOSE, message)
-    run(dlg)
-    destroy(dlg)
+for (func, flag) in (
+        (:info_dialog, GtkMessageType.INFO),
+        (:warn_dialog, GtkMessageType.WARNING),
+        (:error_dialog, GtkMessageType.ERROR))
+    @eval function $func(message::String, parent = GtkNullContainer())
+        w = GtkMessageDialogLeaf(ccall((:gtk_message_dialog_new,libgtk), Ptr{GObject},
+            (Ptr{GObject},Cint,Cint,Cint,Ptr{Uint8}),
+            parent, GtkDialogFlags.DESTROY_WITH_PARENT,
+            $flag, GtkButtonsType.CLOSE, C_NULL))
+        setproperty!(w, :text, bytestring(message))
+        run(w)
+        destroy(w)
+    end
 end
-
-#GtkSeparator — A separator widget