Skip to content

Commit 8067e74

Browse files
fix stuff
1 parent 122f445 commit 8067e74

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

.github/workflows/test_GNNLux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
Pkg.test("GNNLux"; coverage=true)
4242
- uses: julia-actions/julia-processcoverage@v1
4343
with:
44-
directories: GNNLux/src,GNNLux/ext,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
44+
directories: GNNLux/src,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
4545
- uses: codecov/codecov-action@v5
4646
with:
4747
token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/test_GraphNeuralNetworks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
Pkg.test("GraphNeuralNetworks"; coverage=true)
4242
- uses: julia-actions/julia-processcoverage@v1
4343
with:
44-
directories: GraphNeuralNetworks/src,GraphNeuralNetworks/ext,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
44+
directories: GraphNeuralNetworks/src,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
4545
- uses: codecov/codecov-action@v5
4646
with:
4747
token: ${{ secrets.CODECOV_TOKEN }}

GraphNeuralNetworks/test/layers/conv.jl

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,17 @@ end
102102
l = ChebConv(D_IN => D_OUT, k)
103103
for g in TEST_GRAPHS
104104
has_isolated_nodes(g) && continue
105-
broken = get_graph_type(g) == :sparse || gpu_backend() == "AMDGPU"
105+
106+
broken = gpu_backend() == "AMDGPU"
106107
@test size(l(g, g.x)) == (D_OUT, g.num_nodes) broken=broken
108+
109+
if gpu_backend() == "AMDGPU"
110+
broken = true
111+
elseif gpu_backend() == "CUDA" && get_graph_type(g) == :sparse
112+
broken = true
113+
else
114+
broken = false
115+
end
107116
@test test_gradients(
108117
l, g, g.x, rtol = RTOL_LOW, test_gpu = true, compare_finite_diff = false
109118
) broken=broken

GraphNeuralNetworks/test/test_module.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
using Pkg
44

55
## Uncomment below to change the default test settings
6-
# ENV["GNN_TEST_CUDA"] = "true"
6+
ENV["GNN_TEST_CUDA"] = "true"
77
# ENV["GNN_TEST_AMDGPU"] = "true"
88
# ENV["GNN_TEST_Metal"] = "true"
99

@@ -39,7 +39,7 @@ using SparseArrays
3939
export mean, randn, SparseArrays, AbstractSparseMatrix
4040

4141
# from Flux.jl
42-
export Flux, gradient, Dense, Chain, relu
42+
export Flux, gradient, Dense, Chain, relu,
4343
BatchNorm, LayerNorm, Dropout, Parallel,
4444
gpu_device, cpu_device, get_device,
4545
CPUDevice, CUDADevice, AMDGPUDevice, MetalDevice

0 commit comments

Comments
 (0)