Skip to content

Commit 91d38b8

Browse files
fix erdos renyi generator (#174)
1 parent 61c2a66 commit 91d38b8

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/SimpleGraphs/generators/randgraphs.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function SimpleGraph{T}(
2727
maxe = div(Int(nv) * (nv - 1), 2)
2828
@assert(ne <= maxe, "Maximum number of edges for this graph is $maxe")
2929
rng = rng_from_rng_or_seed(rng, seed)
30-
ne > div((2 * maxe), 3) && return complement(SimpleGraph(tnv, maxe - ne, rng=rng, seed=seed))
30+
ne > div((2 * maxe), 3) && return complement(SimpleGraph(tnv, maxe - ne, rng=rng))
3131

3232
g = SimpleGraph(tnv)
3333

@@ -70,7 +70,7 @@ function SimpleDiGraph{T}(
7070
maxe = Int(nv) * (nv - 1)
7171
@assert(ne <= maxe, "Maximum number of edges for this graph is $maxe")
7272
rng = rng_from_rng_or_seed(rng, seed)
73-
ne > div((2 * maxe), 3) && return complement(SimpleDiGraph{T}(tnv, maxe - ne; rng=rng, seed=seed))
73+
ne > div((2 * maxe), 3) && return complement(SimpleDiGraph{T}(tnv, maxe - ne; rng=rng))
7474
g = SimpleDiGraph(tnv)
7575
while g.ne < ne
7676
source = rand(rng, one(T):tnv)
@@ -789,7 +789,7 @@ function random_regular_graph(
789789
end
790790
rng = rng_from_rng_or_seed(rng, seed)
791791
if (k > n / 2) && iseven(n * (n - k - 1))
792-
return complement(random_regular_graph(n, n - k - 1; rng=rng, seed=seed))
792+
return complement(random_regular_graph(n, n - k - 1; rng=rng))
793793
end
794794

795795
edges = _try_creation(n, k, rng)
@@ -876,7 +876,7 @@ function random_regular_digraph(
876876
end
877877
rng = rng_from_rng_or_seed(rng, seed)
878878
if (k > n / 2) && iseven(n * (n - k - 1))
879-
return complement(random_regular_digraph(n, n - k - 1; dir=dir, rng=rng, seed=seed))
879+
return complement(random_regular_digraph(n, n - k - 1; dir=dir, rng=rng))
880880
end
881881
cs = collect(2:n)
882882
i = 1
@@ -962,7 +962,7 @@ function stochastic_block_model(
962962

963963
m = a == b ? div(n[a] * (n[a] - 1), 2) : n[a] * n[b]
964964
p = a == b ? n[a] * c[a, b] / (2m) : n[a] * c[a, b] / m
965-
nedg = randbn(m, p; rng=rng, seed=seed)
965+
nedg = randbn(m, p; rng=rng)
966966
rb = (cum[b] + 1):cum[b + 1]
967967
i = 0
968968
while i < nedg

test/simplegraphs/generators/randgraphs.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@
4747
@test erdos_renyi(5, 1.0, is_directed=true, rng=rng) == complete_digraph(5)
4848
@test erdos_renyi(5, 2.1, rng=rng) == complete_graph(5)
4949
@test erdos_renyi(5, 2.1, is_directed=true, rng=rng) == complete_digraph(5)
50+
51+
# issue #173
52+
er = erdos_renyi(4, 6, seed=1)
53+
@test nv(er) == 4
54+
@test ne(er) == 6
5055
end
5156

5257
@testset "expected degree" begin

0 commit comments

Comments
 (0)