Skip to content

Conversation

@Krastanov
Copy link
Member

No description provided.

@m-fila
Copy link
Contributor

m-fila commented Nov 6, 2025

Sorry I didn't follow up in #466
I'm not sure about the stability of v2 yet. Some projects (SciML) seem to already moved to it. Yet the tooling doesn't seem to fully support it. I often use vscode which is stuck with v1, julia-vscode/julia-vscode#3819, and then I end up constantly reformatting code between v2-v1-v2 which sometimes breaks something on the way

@Krastanov
Copy link
Member Author

Thanks for looking into this! I have not thought about it much but I am still in favor of figuring out a way that still sticks to using Formatter v2.

@Krastanov Krastanov force-pushed the sk/formatter2 branch 3 times, most recently from 8756a45 to 4c99e22 Compare November 7, 2025 05:09
@Krastanov Krastanov changed the title try formatter v2 again try formatter v2 again and bump DataStructures.jl to avoid warnings Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (531260f) to head (3661208).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         121      121           
  Lines        7020     7020           
=======================================
  Hits         6821     6821           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Member Author

This should be ready for review now. Please do not squash if you merge, so that we can have the single re-formatting commit hidden from git-blame in the future.

@Krastanov Krastanov requested a review from m-fila November 7, 2025 05:32
Copy link
Contributor

@m-fila m-fila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit config could be also updated to 2.2 or maybe removed if it's not run in the CI

There are still some warnings from deprecated methods for PriorityQueue. You can pick up my fix for them bdc360f or I can open another PR later

@Krastanov
Copy link
Member Author

Thanks for the fix! I do not know how I missed something with so many loud warnings. That is now cherrypicked and the precommit config file is also removed.

I will wait for tests to pass without warnings and will merge. After that I will setup a git blame exclusion file so that the formatting commit does not pollute git blame.

@Krastanov Krastanov merged commit 83c3b1c into master Nov 7, 2025
13 checks passed
@Krastanov Krastanov deleted the sk/formatter2 branch November 7, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants