-
Notifications
You must be signed in to change notification settings - Fork 115
try formatter v2 again and bump DataStructures.jl to avoid warnings #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry I didn't follow up in #466 |
|
Thanks for looking into this! I have not thought about it much but I am still in favor of figuring out a way that still sticks to using Formatter v2. |
8756a45 to
4c99e22
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 121 121
Lines 7020 7020
=======================================
Hits 6821 6821
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f9c2702 to
0241cee
Compare
|
This should be ready for review now. Please do not squash if you merge, so that we can have the single re-formatting commit hidden from git-blame in the future. |
m-fila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre-commit config could be also updated to 2.2 or maybe removed if it's not run in the CI
There are still some warnings from deprecated methods for PriorityQueue. You can pick up my fix for them bdc360f or I can open another PR later
0241cee to
3661208
Compare
|
Thanks for the fix! I do not know how I missed something with so many loud warnings. That is now cherrypicked and the precommit config file is also removed. I will wait for tests to pass without warnings and will merge. After that I will setup a git blame exclusion file so that the formatting commit does not pollute git blame. |
No description provided.