From a4ca6e80f32872b80b0d614d2ea4dcb75631f4aa Mon Sep 17 00:00:00 2001 From: fchrstou Date: Thu, 4 Apr 2024 13:18:45 +0200 Subject: [PATCH 1/9] Delete much CI. Upgrade upload-artifact@v4 --- .github/workflows/ci.yml | 4 ---- .github/workflows/runbenchandupload.yml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b03ecdca5..decde5cd3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,13 +18,9 @@ jobs: fail-fast: false matrix: version: - - 'nightly' - '1' - - '1.6' os: - ubuntu-latest - - macos-latest - - windows-latest arch: - x64 include: diff --git a/.github/workflows/runbenchandupload.yml b/.github/workflows/runbenchandupload.yml index 1f804067a..06624adb2 100644 --- a/.github/workflows/runbenchandupload.yml +++ b/.github/workflows/runbenchandupload.yml @@ -54,7 +54,7 @@ jobs: PR_NUMBER: ${{ github.event.pull_request.number }} run: | echo $PR_NUMBER > .benchmarkci/pr_number - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: BenchmarkResults path: .benchmarkci/ From 044fda6519124787e3f85dd0742f3802c7c60aa5 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Thu, 4 Apr 2024 15:22:28 +0200 Subject: [PATCH 2/9] completely delete tests --- .github/workflows/ci.yml | 73 ---------------------------------------- 1 file changed, 73 deletions(-) delete mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml deleted file mode 100644 index decde5cd3..000000000 --- a/.github/workflows/ci.yml +++ /dev/null @@ -1,73 +0,0 @@ -name: CI -env: - JULIA_NUM_THREADS: 2 -on: - pull_request: - branches: - - master - push: - branches: - - master - tags: '*' -jobs: - test: - name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} - runs-on: ${{ matrix.os }} - continue-on-error: ${{ matrix.allow_failure }} - strategy: - fail-fast: false - matrix: - version: - - '1' - os: - - ubuntu-latest - arch: - - x64 - include: - - version: 'nightly' - allow_failure: true - - version: '1' - allow_failure: false - - version: '1.6' - allow_failure: false - steps: - - uses: actions/checkout@v4 - - uses: julia-actions/setup-julia@v1 - with: - version: ${{ matrix.version }} - arch: ${{ matrix.arch }} - - uses: actions/cache@v4 - env: - cache-name: cache-artifacts - with: - path: ~/.julia/artifacts - key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }} - restore-keys: | - ${{ runner.os }}-test-${{ env.cache-name }}- - ${{ runner.os }}-test- - ${{ runner.os }}- - - uses: julia-actions/julia-buildpkg@v1 - - uses: julia-actions/julia-runtest@v1 - - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v4 - with: - file: lcov.info - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: false - docs: - name: Documentation - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: julia-actions/setup-julia@v1 - with: - version: '1' - - run: | - julia --project=docs -e ' - using Pkg - Pkg.develop(PackageSpec(path=pwd())) - Pkg.instantiate()' - - run: julia --project=docs docs/make.jl - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} From a91df0b92c89f68c6455306c252d757e83783190 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Mon, 22 Apr 2024 14:17:33 +0200 Subject: [PATCH 3/9] remove types and branches --- .github/workflows/postbench.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/postbench.yml b/.github/workflows/postbench.yml index e0995c814..bdbc55de0 100644 --- a/.github/workflows/postbench.yml +++ b/.github/workflows/postbench.yml @@ -2,8 +2,8 @@ name: PostBenchmarks on: workflow_run: workflows: [RunUploadBenchmarks] - types: [completed] - branches: [master, benchx] + # types: [completed] + # branches: [master, benchx] jobs: on-success: runs-on: ubuntu-latest From da1abbdb55afcea2a4612a1a10ecb094912216d6 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Mon, 22 Apr 2024 14:19:47 +0200 Subject: [PATCH 4/9] Trivial change test PR bench --- benchmark/benchmarks.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/benchmarks.jl b/benchmark/benchmarks.jl index b00a2e888..a6429be4f 100644 --- a/benchmark/benchmarks.jl +++ b/benchmark/benchmarks.jl @@ -12,7 +12,7 @@ const GRAPHS = Dict{String,Graph}( "path500" => path_graph(500), ) -serialbenchmarks = [ +const serialbenchmarks = [ "serial/core.jl", "serial/connectivity.jl", "serial/centrality.jl", From 0c4c7b7bfa436dc562e0dfe5e9efe7a9a83f1393 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Mon, 22 Apr 2024 18:26:31 +0200 Subject: [PATCH 5/9] post deps --- .github/workflows/postbench.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/postbench.yml b/.github/workflows/postbench.yml index bdbc55de0..cdb71d0ee 100644 --- a/.github/workflows/postbench.yml +++ b/.github/workflows/postbench.yml @@ -33,6 +33,8 @@ jobs: - name: 'Unzip artifact' run: unzip BenchmarkResults.zip -d .benchmarkci/ + - name: install dependencies + run: julia -e 'using Pkg; pkg"add PkgBenchmark BenchmarkCI@0.1"' - name: 'Post results test 1' run: julia -e 'using BenchmarkCI; BenchmarkCI.postjudge()' env: From 2bd72f62e71604bcd54a723fcef573adebf621d3 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Mon, 22 Apr 2024 18:28:56 +0200 Subject: [PATCH 6/9] test PR --- benchmark/benchmarks.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/benchmarks.jl b/benchmark/benchmarks.jl index a6429be4f..b00a2e888 100644 --- a/benchmark/benchmarks.jl +++ b/benchmark/benchmarks.jl @@ -12,7 +12,7 @@ const GRAPHS = Dict{String,Graph}( "path500" => path_graph(500), ) -const serialbenchmarks = [ +serialbenchmarks = [ "serial/core.jl", "serial/connectivity.jl", "serial/centrality.jl", From 09d91c51aa6c6626cd057360010078f34ea0783a Mon Sep 17 00:00:00 2001 From: fchrstou Date: Tue, 23 Apr 2024 13:23:33 +0200 Subject: [PATCH 7/9] read PR number --- .github/workflows/postbench.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/postbench.yml b/.github/workflows/postbench.yml index cdb71d0ee..5b6260cbe 100644 --- a/.github/workflows/postbench.yml +++ b/.github/workflows/postbench.yml @@ -2,8 +2,8 @@ name: PostBenchmarks on: workflow_run: workflows: [RunUploadBenchmarks] - # types: [completed] - # branches: [master, benchx] + types: [completed] + branches: [master] jobs: on-success: runs-on: ubuntu-latest @@ -52,12 +52,14 @@ jobs: issue_number: issue_number, body: 'Thank you for the PR!' }); + - name: `Read PR number` + run: echo "{MY_PR_NUMBER}=$(cat .benchmarkci/pr_number)" >> $GITHUB_ENV - name: 'Comment on PR test 3' - run: gh pr comment "$NUMBER" --body "$BODY" + run: gh pr comment "$MY_PR_NUMBER" --body "$BODY" env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} GH_REPO: ${{ github.repository }} - NUMBER: ${{ github.event.pull_request.number }} + # NUMBER: ${{ github.event.pull_request.number }} BODY: > This pr comment is testing. **This should be bold** From 1d477e6b46c7d89d23f8557e827ee0f7629f6d53 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Tue, 23 Apr 2024 13:24:58 +0200 Subject: [PATCH 8/9] small error --- .github/workflows/postbench.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/postbench.yml b/.github/workflows/postbench.yml index 5b6260cbe..039ecabec 100644 --- a/.github/workflows/postbench.yml +++ b/.github/workflows/postbench.yml @@ -52,7 +52,7 @@ jobs: issue_number: issue_number, body: 'Thank you for the PR!' }); - - name: `Read PR number` + - name: 'Read PR number' run: echo "{MY_PR_NUMBER}=$(cat .benchmarkci/pr_number)" >> $GITHUB_ENV - name: 'Comment on PR test 3' run: gh pr comment "$MY_PR_NUMBER" --body "$BODY" From 8a9bd5201d13ddfa4de358e9c0a10ab8fe8bc9f5 Mon Sep 17 00:00:00 2001 From: fchrstou Date: Tue, 23 Apr 2024 14:20:36 +0200 Subject: [PATCH 9/9] delete branches --- .github/workflows/postbench.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/postbench.yml b/.github/workflows/postbench.yml index 039ecabec..c0dc22a40 100644 --- a/.github/workflows/postbench.yml +++ b/.github/workflows/postbench.yml @@ -3,7 +3,6 @@ on: workflow_run: workflows: [RunUploadBenchmarks] types: [completed] - branches: [master] jobs: on-success: runs-on: ubuntu-latest