Apply suggestions from code review

Co-authored-by: Simon Schölly <[email protected]>

Author: hexaeder

src/NetworkLayout.jl

@@ -10,17 +10,17 @@ export LayoutIterator, layout
 """
     AbstractLayout{Dim,Ptype}
 
-Abstract supertype for all layouts. Each layout `Algorithm <: AbstractLayout` needs to
+Abstract supertype for all layouts. Each layout `Layout <: AbstractLayout` needs to
 implement
 
-    layout(algo::Algorithm, adj_matrix)::Vector{Point{Dim,Ptype}}
+    layout(::Layout, adj_matrix)::Vector{Point{Dim,Ptype}}
 
 which takes the adjacency matrix representation of a network and returns a list of
-node positions. Each `Algorithm` object holds all of the necessary parameters.
+node positions. Each `Layout` object holds all of the necessary parameters.
 
-By implementing `layout` the algorithm also inherits the function-like property
+By implementing `layout` the Layout also inherits the function-like property
 
-    Algorithm(; kwargs...)(adj_matrix) -> node_positions
+    Layout(; kwargs...)(adj_matrix) -> node_positions
 """
 abstract type AbstractLayout{Dim,Ptype} end
 

src/buchheim.jl

@@ -58,7 +58,7 @@ function adj_mat_to_list(M::AbstractMatrix)
     N = size(M, 1)
     list = Vector{Vector{Int}}(undef, N)
     for i in 1:N
-        list[i] = findall(x -> !iszero(x), view(M, i, :))
+        list[i] = findall(!iszero, view(M, i, :))
     end
     return list
 end

src/squaregrid.jl

@@ -34,10 +34,7 @@ function layout(algo::SquareGrid{Ptype}, adj_matrix::AbstractMatrix) where {Ptyp
     M = N + length(algo.skip)
 
     if algo.cols === :auto
-        cols = 0
-        while (cols^2 < M)
-            cols += 1
-        end
+        cols = (M == 0) ? 0 : (isqrt(M - 1) + 1)
     else
         cols = algo.cols
     end