Skip to content

Commit 5d76196

Browse files
matbesanconsbromberger
authored andcommitted
Fix deprecations (#55)
* fix deprecation, version bounds * travis correct path
1 parent c7471c3 commit 5d76196

File tree

6 files changed

+24
-27
lines changed

6 files changed

+24
-27
lines changed

.travis.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,5 @@ git:
2525
#before_script: # homebrew for mac
2626
# - if [ $TRAVIS_OS_NAME = osx ]; then brew install gcc; fi
2727

28-
# uncomment the following lines to override the default test script
29-
# script:
30-
# - if [[ -a .git/shallow ]]; then git fetch --unshallow; fi
31-
# - julia -e 'using Pkg; Pkg.add(PackageSpec(url=pwd())); Pkg.build("SimpleWeightedGraphs"); Pkg.test("SimpleWeightedGraphs"; coverage=true)'
3228
after_success:
33-
# push coverage results to Codecov
34-
- julia -e 'using Pkg; cd(Pkg.dir("SimpleWeightedGraphs")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'
29+
- julia -e 'import Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder()); Coveralls.submit(process_folder())'

Project.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
88
Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a"
99
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
1010
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
11+
12+
[compat]
13+
julia = "1"
14+
LightGraphs = "1.3"

REQUIRE

Lines changed: 0 additions & 2 deletions
This file was deleted.

src/overrides.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function laplacian_matrix(g::AbstractSimpleWeightedGraph, T::DataType=weighttype
3939
degree_matrix(g, T; dir=dir) - adjacency_matrix(g, T; dir=dir)
4040
end
4141

42-
function pagerank(g::SimpleWeightedDiGraph, α=0.85, n=100::Integer, ϵ=1.0e-6)
42+
function pagerank(g::SimpleWeightedDiGraph, α=0.85, n::Integer=100, ϵ=1.0e-6)
4343
A = weights(g)
4444
S = vec(sum(A, dims=1))
4545
S = 1 ./ S

test/overrides.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
@testset "Overrides" begin
2-
g3 = SimpleWeightedGraph(PathGraph(5))
2+
g3 = SimpleWeightedGraph(path_graph(5))
33
g3_d = [1. 0. 0. 0. 0.;
44
0. 2. 0. 0. 0.;
55
0. 0. 2. 0. 0.;
@@ -37,7 +37,7 @@
3737
@test adjacency_matrix(g; dir=:out) == adjacency_matrix(g; dir=:in)'
3838
@test issymmetric(laplacian_matrix(g))
3939
@test laplacian_matrix(g, Float64) g3_l
40-
@test g[1:3] == SimpleWeightedGraph{eltype(g), weighttype(g)}(PathGraph(3))
40+
@test g[1:3] == SimpleWeightedGraph{eltype(g), weighttype(g)}(path_graph(3))
4141
gx = copy(g)
4242
add_edge!(gx, 2, 3, 99)
4343
gi = gx[2:4]
@@ -66,7 +66,7 @@
6666
@test_throws ErrorException pagerank(g, 2)
6767
@test_throws ErrorException pagerank(g, 0.85, 2)
6868

69-
gc = SimpleWeightedDiGraph(PathDiGraph(2), 2)
69+
gc = SimpleWeightedDiGraph(path_digraph(2), 2)
7070
@test g[2:3] == SimpleWeightedDiGraph{eltype(g5), weighttype(g5)}(gc)
7171
@test weights(g[2:3])[1, 2] == 2
7272
end

test/simpleweightedgraph.jl

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ using SimpleWeightedGraphs
99
@test @inferred(eltype(SimpleWeightedGraph(adjmx1))) == Int
1010
@test_throws ErrorException SimpleWeightedGraph(adjmx2)
1111

12-
@test @inferred(ne(SimpleWeightedGraph(PathDiGraph(5)))) == 4
12+
@test @inferred(ne(SimpleWeightedGraph(path_digraph(5)))) == 4
1313
@test @inferred(!is_directed(SimpleWeightedGraph))
1414

1515
@test @inferred(eltype(SimpleWeightedDiGraph())) == Int
1616
@test @inferred(eltype(SimpleWeightedDiGraph(adjmx2))) == Int
17-
@test @inferred(ne(SimpleWeightedDiGraph(PathGraph(5)))) == 8
17+
@test @inferred(ne(SimpleWeightedDiGraph(path_graph(5)))) == 8
1818
@test @inferred(is_directed(SimpleWeightedDiGraph))
1919

2020

@@ -23,7 +23,7 @@ using SimpleWeightedGraphs
2323
@test @inferred(!add_vertices!(gbig, 10))
2424
end
2525

26-
gdx = SimpleWeightedDiGraph(PathDiGraph(4))
26+
gdx = SimpleWeightedDiGraph(path_digraph(4))
2727
gx = SimpleWeightedGraph()
2828
for g in testgraphs(gx)
2929
T = eltype(g)
@@ -41,7 +41,7 @@ using SimpleWeightedGraphs
4141
@test sprint(show, g) == "{5, 0} directed simple $T graph with $U weights"
4242
end
4343

44-
gx = SimpleWeightedGraph(PathGraph(4))
44+
gx = SimpleWeightedGraph(path_graph(4))
4545

4646
gc = copy(gx)
4747
@test_logs (:warn, "Note: adding edges with a zero weight to this graph type has no effect.") add_edge!(gc, 4, 1, 0.0)
@@ -56,13 +56,13 @@ using SimpleWeightedGraphs
5656
@test @inferred(has_edge(g, 3, 2))
5757

5858
gc = copy(g)
59-
@test @inferred(add_edge!(gc, 4=>1)) && gc == SimpleWeightedGraph(CycleGraph(4))
59+
@test @inferred(add_edge!(gc, 4=>1)) && gc == SimpleWeightedGraph(cycle_graph(4))
6060
@test @inferred(has_edge(gc, 4=>1)) && has_edge(gc, 0x04=>0x01)
6161
gc = copy(g)
62-
@test @inferred(add_edge!(gc, (4,1))) && gc == SimpleWeightedGraph(CycleGraph(4))
62+
@test @inferred(add_edge!(gc, (4,1))) && gc == SimpleWeightedGraph(cycle_graph(4))
6363
@test @inferred(has_edge(gc, (4,1))) && has_edge(gc, (0x04, 0x01))
6464
gc = copy(g)
65-
@test add_edge!(gc, 4, 1) && gc == SimpleWeightedGraph(CycleGraph(4))
65+
@test add_edge!(gc, 4, 1) && gc == SimpleWeightedGraph(cycle_graph(4))
6666

6767
@test @inferred(inneighbors(g, 2)) == @inferred(outneighbors(g, 2)) == @inferred(neighbors(g,2)) == [1,3]
6868
@test @inferred(add_vertex!(gc)) # out of order, but we want it for issubset
@@ -104,7 +104,7 @@ using SimpleWeightedGraphs
104104
@test @inferred(has_edge(g, e))
105105
end
106106

107-
gdx = SimpleWeightedDiGraph(PathDiGraph(4))
107+
gdx = SimpleWeightedDiGraph(path_digraph(4))
108108

109109
gc = copy(gdx)
110110
@test_logs (:warn, "Note: adding edges with a zero weight to this graph type has no effect.") add_edge!(gc, 4, 1, 0.0)
@@ -122,13 +122,13 @@ using SimpleWeightedGraphs
122122
@test @inferred(!has_edge(g, 3, 2))
123123

124124
gc = copy(g)
125-
@test @inferred(add_edge!(gc, 4=>1)) && gc == SimpleWeightedDiGraph(CycleDiGraph(4))
125+
@test @inferred(add_edge!(gc, 4=>1)) && gc == SimpleWeightedDiGraph(cycle_digraph(4))
126126
@test @inferred(has_edge(gc, 4=>1)) && has_edge(gc, 0x04=>0x01)
127127
gc = copy(g)
128-
@test @inferred(add_edge!(gc, (4,1))) && gc == SimpleWeightedDiGraph(CycleDiGraph(4))
128+
@test @inferred(add_edge!(gc, (4,1))) && gc == SimpleWeightedDiGraph(cycle_digraph(4))
129129
@test @inferred(has_edge(gc, (4,1))) && has_edge(gc, (0x04, 0x01))
130130
gc = @inferred(copy(g))
131-
@test @inferred(add_edge!(gc, 4, 1)) && gc == SimpleWeightedDiGraph(CycleDiGraph(4))
131+
@test @inferred(add_edge!(gc, 4, 1)) && gc == SimpleWeightedDiGraph(cycle_digraph(4))
132132

133133
@test @inferred(inneighbors(g, 2)) == [1]
134134
@test @inferred(outneighbors(g, 2)) == @inferred(neighbors(g,2)) == [3]
@@ -172,7 +172,7 @@ using SimpleWeightedGraphs
172172
@test @inferred(has_edge(g, e))
173173
end
174174

175-
gdx = SimpleWeightedDiGraph(CompleteDiGraph(4))
175+
gdx = SimpleWeightedDiGraph(complete_digraph(4))
176176
for g in testdigraphs(gdx)
177177
@test rem_vertex!(g, 2)
178178
@test nv(g) == 3 && ne(g) == 6
@@ -181,7 +181,7 @@ using SimpleWeightedGraphs
181181
@test sum(weights(g)) == 2 * ne(g) * 3
182182
@test @inferred(get_weight(g, 1, 2)) == 3
183183

184-
g = SimpleWeightedDiGraph(PathGraph(5), 4.0)
184+
g = SimpleWeightedDiGraph(path_graph(5), 4.0)
185185
@test sum(weights(g)) == ne(g) * 4.0
186186

187187
gx = Graph(4,3)
@@ -194,11 +194,11 @@ using SimpleWeightedGraphs
194194
@test eltype(SimpleWeightedGraph(g)) == eltype(g)
195195
end
196196

197-
s = SimpleWeightedGraph(PathGraph(5), 2)
197+
s = SimpleWeightedGraph(path_graph(5), 2)
198198
s2 = SimpleWeightedGraph([1,2,3,4], [2,3,4,5], [2,2,2,2])
199199
@test s == s2
200200

201-
s = SimpleWeightedDiGraph(PathDiGraph(5), 2)
201+
s = SimpleWeightedDiGraph(path_digraph(5), 2)
202202
s2 = SimpleWeightedDiGraph([1,2,3,4], [2,3,4,5], [2,2,2,2])
203203
@test s == s2
204204

0 commit comments

Comments
 (0)