Skip to content

Conversation

kosuri-indu
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 97.88732% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.65%. Comparing base (ee1080c) to head (e99c878).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 96.96% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   95.97%   96.65%   +0.68%     
==========================================
  Files           3        4       +1     
  Lines         149      269     +120     
==========================================
+ Hits          143      260     +117     
- Misses          6        9       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kosuri-indu kosuri-indu changed the title Post Cohort Feasibility [FEATURE] Post Cohort Feasibility Aug 10, 2025
@kosuri-indu
Copy link
Member Author

Hey @TheCedarPrince, updated the PR as per main branch!

Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small docs changes and I think this is ready to merge!

@TheCedarPrince
Copy link
Member

Also, there does seem to be one failing error locally:

Test Summary:     | Pass  Total  Time
Utility Functions |   62     62  8.1s
Test Summary:       | Pass  Total  Time
Pre-cohort Analysis |   60     60  9.4s
create_individual_profiles: Test Failed at /home/thecedarprince/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:56
  Expression: create_individual_profiles(cohort_definition_id = 1, cohort_df = test_cohort_df, conn = TEST_CONN, covariate_funcs = [occ.GetPatientGender], sc
hema = "main", dialect = :sqlite)
    Expected: ArgumentError
  No exception thrown

Stacktrace:
 [1] macro expansion
   @ ~/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:56 [inlined]
 [2] macro expansion
   @ ~/.julia/juliaup/julia-1.11.4+0.x64.linux.gnu/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
 [3] top-level scope
   @ ~/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:2
Test Summary:                | Pass  Fail  Total  Time
Post-cohort Analysis         |   25     1     26  7.4s
  create_individual_profiles |   15     1     16  5.3s
  create_cartesian_profiles  |    6            6  1.3s
  Edge Cases and Integration |    4            4  0.2s
ERROR: LoadError: Some tests did not pass: 25 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /home/thecedarprince/FOSS/OMOPCDMFeasibility.jl/test/runtests.jl:33
ERROR: Package OMOPCDMFeasibility errored during testing

@kosuri-indu
Copy link
Member Author

Hey @TheCedarPrince, I updated the code, do check upon the test suite, and let me know if it is running okay.

@TheCedarPrince TheCedarPrince merged commit 1359c60 into master Sep 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants