-
Notifications
You must be signed in to change notification settings - Fork 0
[FEATURE] Post Cohort Feasibility #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 95.97% 96.65% +0.68%
==========================================
Files 3 4 +1
Lines 149 269 +120
==========================================
+ Hits 143 260 +117
- Misses 6 9 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @TheCedarPrince, updated the PR as per main branch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small docs changes and I think this is ready to merge!
Also, there does seem to be one failing error locally: Test Summary: | Pass Total Time
Utility Functions | 62 62 8.1s
Test Summary: | Pass Total Time
Pre-cohort Analysis | 60 60 9.4s
create_individual_profiles: Test Failed at /home/thecedarprince/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:56
Expression: create_individual_profiles(cohort_definition_id = 1, cohort_df = test_cohort_df, conn = TEST_CONN, covariate_funcs = [occ.GetPatientGender], sc
hema = "main", dialect = :sqlite)
Expected: ArgumentError
No exception thrown
Stacktrace:
[1] macro expansion
@ ~/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:56 [inlined]
[2] macro expansion
@ ~/.julia/juliaup/julia-1.11.4+0.x64.linux.gnu/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
[3] top-level scope
@ ~/FOSS/OMOPCDMFeasibility.jl/test/test_postcohort.jl:2
Test Summary: | Pass Fail Total Time
Post-cohort Analysis | 25 1 26 7.4s
create_individual_profiles | 15 1 16 5.3s
create_cartesian_profiles | 6 6 1.3s
Edge Cases and Integration | 4 4 0.2s
ERROR: LoadError: Some tests did not pass: 25 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /home/thecedarprince/FOSS/OMOPCDMFeasibility.jl/test/runtests.jl:33
ERROR: Package OMOPCDMFeasibility errored during testing |
Hey @TheCedarPrince, I updated the code, do check upon the test suite, and let me know if it is running okay. |
No description provided.