fix Dic bug

Author: CarloLucibello

Manifest.toml

@@ -0,0 +1,2 @@
+# This file is machine-generated - editing it directly is not advised
+

src/BSON.jl

@@ -5,20 +5,7 @@ export bson
 
 using Core: SimpleVector, TypeName
 
-struct BSONDict <: AbstractDict{Symbol,Any}
-  d::Dict{Symbol,Any}
-  BSONDict(v...) = new(Dict{Symbol,Any}(v...))
-end
-# implement some of the needed Dict methods
-Base.length(bd::BSONDict) = length(bd.d)
-Base.isempty(bd::BSONDict) = length(bd.d)==0
-Base.setindex!(bd::BSONDict, v, k) = setindex!(bd.d, v, k)
-Base.getindex(bd::BSONDict, k) = getindex(bd.d, k)
-Base.iterate(bd::BSONDict) = iterate(bd.d)
-Base.iterate(bd::BSONDict, i) = iterate(bd.d, i)
-Base.get(bd::BSONDict, k, d) = get(bd.d, k, d)
-Base.delete!(bd::BSONDict, k) = delete!(bd.d, k)
-
+const BSONDict = Dict{Symbol,Any}
 const BSONArray = Vector{Any}
 const Primitive = Union{Nothing,Bool,Int32,Int64,Float64,String,Vector{UInt8},BSONDict,BSONArray}
 

src/extensions.jl

@@ -1,4 +1,5 @@
 lower(x::Dict{Symbol}) = BSONDict(x)
+lower(x::BSONDict) = BSONDict(x)
 
 # Basic Types
 

test.bson

@@ -1,7 +1,17 @@
 using BSON
 using Test
 
-roundtrip_equal(x) = BSON.roundtrip(x) == x
+function roundtrip_equal(x)
+  y = BSON.roundtrip(x)
+  typeof(y) == typeof(x) && x == y
+end
+
+# avoid hitting bug where
+# Dict{Symbol,T} -> Dict{Symbol,Any}
+function roundtrip_equal(x::Dict{Symbol}) 
+  y = BSON.roundtrip(x)
+  y isa Dict{Symbol} && y == x
+end
 
 mutable struct Foo
   x