all Chunkeds are chunked (#226)

* all `Chunked`s are chunked

* add test

Author: tiemvanderdeure

src/broadcast.jl

@@ -57,7 +57,7 @@ end
 function common_chunks(s, args...)
     N = length(s)
     chunkedarrays = reduce(args; init=()) do acc, x
-        haschunks(x) === Chunked() ? (acc..., x) : acc
+        haschunks(x) isa Chunked ? (acc..., x) : acc
     end
     all(ar -> isa(eachchunk(ar), GridChunks), chunkedarrays) ||
         error("Currently only chunks of type GridChunks can be merged by broadcast")

test/runtests.jl

@@ -368,8 +368,10 @@ import Statistics: mean
 end
 
 @testset "Broadcast" begin
-    a_disk1 = AccessCountDiskArray(rand(10, 9, 2); chunksize=(5, 3, 2))
-    test_broadcast(a_disk1)
+    for batchstrategy in (DiskArrays.ChunkRead(), DiskArrays.SubRanges())
+        a_disk1 = AccessCountDiskArray(rand(10, 9, 2); chunksize=(5, 3, 2), batchstrategy)
+        test_broadcast(a_disk1)
+    end
 end
 
 @testset "zip" begin