Skip to content

Remove ascii check in obj file parsing#102

Merged
SimonDanisch merged 1 commit intomasterfrom
ff/ascii
Dec 15, 2024
Merged

Remove ascii check in obj file parsing#102
SimonDanisch merged 1 commit intomasterfrom
ff/ascii

Conversation

@ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 15, 2024

Fixes #101 by removing the ascii check. We're not indexing the string directly so I don't see why we couldn't allow unicode. The check has been there since the initial version (Julia ~0.4) of this file (as isvalid()) so it doesn't seem like it's been introduced to fix anything specific.

@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (fd17a83) to head (0ddc863).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   74.72%   74.69%   -0.04%     
==========================================
  Files          10       10              
  Lines         736      735       -1     
==========================================
- Hits          550      549       -1     
  Misses        186      186              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonDanisch SimonDanisch merged commit 96662c2 into master Dec 15, 2024
4 checks passed
@SimonDanisch SimonDanisch deleted the ff/ascii branch December 15, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with UTF-8 symbol in OBJ comment

2 participants