Merge pull request #19 from giordano/windows-tests

Run Travis on 32-bit systems and Windows and fix Windows errors

Author: staticfloat

.travis.yml

@@ -3,6 +3,14 @@ language: julia
 os:
   - linux
   - osx
+  - windows
+arch:
+  - x64
+  - x86
+matrix:
+  allow_failures:
+    - julia: nightly
+    - arch: x86
 julia:
   - 1.0
   - 1.3

src/Abstract/DynamicLink.jl

@@ -134,9 +134,9 @@ function canonical_rpaths(rpath::RPath)
         paths[idx] = replace(paths[idx], "@executable_path" => origin)
         paths[idx] = abspath(paths[idx])
 
-        # Make sure that if it's a directory, it _always_ has a "/" at the end.
-        if isdir(paths[idx]) && paths[idx][end] != '/'
-            paths[idx] = paths[idx] * "/"
+        # Make sure that if it's a directory, it _always_ has a trailing path separator.
+        if isdir(paths[idx]) && paths[idx][end] != Base.Filesystem.path_separator
+            paths[idx] = paths[idx] * Base.Filesystem.path_separator
         end
     end
     return paths

test/runtests.jl

@@ -46,7 +46,7 @@ function test_libfoo_and_fooifier(fooifier_path, libfoo_path)
             # Ensure that `dir_path` is one of the RPath entries
             rpath = RPath(oh_exe)
             can_paths = canonical_rpaths(rpath)
-            @test abspath(dir_path * "/") in can_paths
+            @test abspath(dir_path * Base.Filesystem.path_separator) in can_paths
 
             # Ensure that `fooifier` is going to try to load `libfoo`:
             foo_libs = find_libraries(oh_exe)