Skip to content

Commit 0cf79a4

Browse files
committed
Tests: Do not assume empty vectors alias
Currently, TS uses Base.mightalias to throw an error if the two inputs to three- arg transcode alias. Two problems here: Base.mightalias is internal, and the new memory PR to Julia changes aliasing of zero-length arrays. The temporary fix for now is to remove the test that tests that zero-length arrays trips the Base.mightalias. Later, let's fix this properly by not relying on Base internals in TS tests.
1 parent 00f2fdb commit 0cf79a4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name = "TranscodingStreams"
22
uuid = "3bb67fe8-82b1-5028-8e26-92a6c54297fa"
33
license = "MIT"
44
authors = ["Kenta Sato <[email protected]>"]
5-
version = "0.10.0"
5+
version = "0.10.1"
66

77
[deps]
88
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

test/codecnoop.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,9 @@
189189
@test transcode(Noop, data) == data
190190
@test transcode(Noop, data) !== data
191191

192-
data = Vector{UInt8}()
192+
data = UInt8[]
193193
@test TranscodingStreams.unsafe_transcode!(Noop(), data, data) == data
194+
data = [0x01, 0x02]
194195
@test_throws AssertionError transcode(Noop(), data, data)
195196
data = b""
196197
@test transcode(Noop(), data) == data

0 commit comments

Comments
 (0)