Base.seek and Base.skip should return stream (#156)

Author: nhz2

src/noop.jl

@@ -66,19 +66,19 @@ end
 function Base.seek(stream::NoopStream, pos::Integer)
     seek(stream.stream, pos)
     initbuffer!(stream.state.buffer1)
-    return
+    return stream
 end
 
 function Base.seekstart(stream::NoopStream)
     seekstart(stream.stream)
     initbuffer!(stream.state.buffer1)
-    return
+    return stream
 end
 
 function Base.seekend(stream::NoopStream)
     seekend(stream.stream)
     initbuffer!(stream.state.buffer1)
-    return
+    return stream
 end
 
 function Base.unsafe_read(stream::NoopStream, output::Ptr{UInt8}, nbytes::UInt)

src/stream.jl

@@ -252,7 +252,7 @@ function Base.skip(stream::TranscodingStream, offset::Integer)
         # TODO: support skip in write mode
         throw(ArgumentError("not in read mode"))
     end
-    return
+    return stream
 end
 
 """

test/codecnoop.jl

@@ -72,13 +72,13 @@
     close(stream)
 
     stream = TranscodingStream(Noop(), IOBuffer(b"foobarbaz"))
-    seek(stream, 2)
+    @test stream == seek(stream, 2)
     @test read(stream, 3) == b"oba"
     seek(stream, 0)
     @test read(stream, 3) == b"foo"
-    seekstart(stream)
+    @test stream == seekstart(stream)
     @test read(stream, 3) == b"foo"
-    seekend(stream)
+    @test stream == seekend(stream)
     @test eof(stream)
     close(stream)
 
@@ -97,7 +97,7 @@
     data = collect(0x00:0x0f)
     stream = TranscodingStream(Noop(), IOBuffer(data), bufsize=2)
     @test read(stream, UInt8) == data[1]
-    skip(stream, 4)
+    @test stream == skip(stream, 4)
     @test read(stream, UInt8) == data[6]
     skip(stream, 3)
     @test read(stream, UInt8) == data[10]