Skip to content

Commit 1dbf35c

Browse files
authored
BREAKING: remove generic seekend method (#229)
1 parent 670ebca commit 1dbf35c

File tree

3 files changed

+2
-23
lines changed

3 files changed

+2
-23
lines changed

src/buffer.jl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,6 @@ function initbuffer!(buf::Buffer)
118118
return buf
119119
end
120120

121-
# Remove all buffered data.
122-
function emptybuffer!(buf::Buffer)
123-
buf.markpos = 0
124-
buf.bufferpos = buf.marginpos = 1
125-
return buf
126-
end
127-
128121
# Make margin with ≥`minsize` and return the size of it.
129122
# If eager is true, it tries to move data even when the buffer has enough margin.
130123
function makemargin!(buf::Buffer, minsize::Int; eager::Bool = false)

src/stream.jl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -289,20 +289,6 @@ function Base.seekstart(stream::TranscodingStream)
289289
return stream
290290
end
291291

292-
function Base.seekend(stream::TranscodingStream)
293-
mode = stream.state.mode
294-
if mode == :read
295-
callstartproc(stream, mode)
296-
emptybuffer!(stream.buffer1)
297-
emptybuffer!(stream.buffer2)
298-
elseif mode === :idle
299-
else
300-
throw_invalid_mode(mode)
301-
end
302-
seekend(stream.stream)
303-
return stream
304-
end
305-
306292

307293
# Read Functions
308294
# --------------

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ using TranscodingStreams:
1717
marginptr, marginsize, marginmem,
1818
readbyte!, writebyte!,
1919
#=ismarked,=# mark!, unmark!, reset!,
20-
makemargin!, emptybuffer!
20+
makemargin!, initbuffer!
2121

2222
@testset "Buffer" begin
2323
buf = Buffer(1024)
@@ -68,7 +68,7 @@ using TranscodingStreams:
6868
writebyte!(buf, 0x99)
6969
margin_size = makemargin!(buf, 20)
7070
@test margin_size >= 20
71-
emptybuffer!(buf)
71+
initbuffer!(buf)
7272
@test makemargin!(buf, 0) === margin_size + 2
7373
end
7474

0 commit comments

Comments
 (0)